Hey,

1.) it says "contextual-tabs-visilibity" in the form. Yes visilibity not visibility.
2.) Why is the content visibility set here? Doesn't this pretty much belong to oa_contextual_tabs?
3.) The visibility setting has no effect, as oa_contextual_tabs.module has no condition before rendering the theme('oa_widgets_visibility_toolbar');

This is all a bit weired. Does somebody agree? Should I supply patches moving things where I think they belong and add conditions for what I assume was intended?

Comments

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski commented
Issue summary: View changes
mpotter’s picture

mpotter CreditAttribution: mpotter commented

Yes, I agree. That needs to move into oa_contextual_tabs as a form_alter or something.

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski commented

So should I open an additional issues in OA Contextual Tabs?

Roadmap:
1.) Fix typo and remove visibility
2.) in OA Contextual Tabs add form alter with the stuff removed in 1.)
3.) Add condition for theme('oa_widgets_visibility_toolbar'); with the value from 2.)

mpotter’s picture

mpotter CreditAttribution: mpotter commented

Yes, that would be a huge help thanks.

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski commented

OK, do we finally agree, that there is no need for compatibility concerning the typo? As the variable didn't do much anyway? I mean, if I change the form identifier, the old value will be lost.

mpotter’s picture

mpotter CreditAttribution: mpotter commented

As long as the default value of TRUE is used on the oa_contextual_tabs side then it should be fine.

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski commented

I was occupied with other work. From what I can tell cloning contextual_tabs and oa_contextual_tabs, this whole thing already happened?

mpotter’s picture

mpotter CreditAttribution: mpotter commented
Status: Active » Fixed

Yep, sorry, should have closed this. It was fixed a while ago.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.