Simplify third-party alters of date_repeat form elements [#2073011]

Thanks for this great module. It's great that date_repeat.module provides the date_repeat_rrule form element!

However, that element becomes quite complex, and I need to tweak it for my site. (Among several changes, I want to by default select the monthly checkboxes - why make the user check 12 boxes?). Core drupal makes this sort-of possible, I can set the #after_build callback for the element. Unfortunately the callback receives the element fully built, and therefor it is very difficult to make the changes I want to make.

Instead I think it's reasonable to let third-party modules alter the element when it is being processed (expanded). All it takes is one call to drupal_alter() to make this possible. I've patched my copy as shown in the patch and I hope you'll consider including this in the module.

Comment	File	Size	Author
#3	date_repeat-simplify_third-party_alters_of_date_repeat_form_elements-2073011-3.patch	640 bytes	steinmb
#3	7.x-2.x: PHP 7.1 & MySQL 5.5, D7 50 pass
	date_repeat_element_alter.diff	892 bytes	Dave Cohen
	7.x-2.x: PHP 7.1 & MySQL 5.5, D7 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 30 October 2018 at 02:06

Issue summary:	View changes
Status:	Active	» Needs review

Thanks for the patch, we'll try to review it soon.

BTW when you upload a patch it helps to set the status to "needs review", that triggers the testbots and lets others know that there's something review.