Randomize shuffles choices incorrectly

This problem actually runs deeper and its actually a pretty serious problem. It looks like the only thing that is being randomized is the display text for the choices. The actual values are still listed as non-randomized, which is why the above poster is seeing the problem above.

When you submit the ballot, what is actually submitted are votes for the non-randomized choices that would've appeared if the display text/labels for the checkboxes were not randomized. Does that make sense?

This is a bug in the /modes/selection module, a component of decisions, within function decisions_selection_voting_form(). The checkboxes' labels are randomized, but the checkboxes' values are always output in numeric order (1,2,3,...). This is due to the use of the $node->choice array index instead of the $node->choice[index]['vote_offset'] in the $list array used for $form['choice']['#options'].

The solution is a small modification to /modes/selection.module. The code below begins at line 219 of the 2011-Feb-25 version of 6.x-1.x-dev.

    //Approval/multiple-choice voting.
    else {
      foreach ($node->choice as $i => $choice) {
        //----- delete or comment out these two lines -----
        //if ($choice['label']) {
        //  $list[$i] = check_plain($choice['label']);
        //----- end delete -----
        //----- add these two lines -----
        if (!empty($choice['label']) && !empty($choice['vote_offset'])) {
          $list[$choice['vote_offset']] = check_plain($choice['label']);
        //----- end addition -----
        }
      }

(Follow)

(retracted)

Looks like this change fixed the issue with radio buttons (THANK YOU!), but we're still only half way there.

1-click forms, or forms with checkboxes (used when the voter isn't limited to only one selection) still have this issue. The code for that is right above the area Robert_T fixed, but I'm having some trouble figuring out how to make a similar change.

I'm using version module 6.x-1.7.