Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options: 

/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global Drupal, jQuery */

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.

Files: field_ui/field_ui.js

CommentFileSizeAuthor
#2 field_ui-js.patch1.88 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented 
core/modules/field_ui/field_ui.js: line 61, col 24, 'updateText' is already defined.
core/modules/field_ui/field_ui.js: line 338, col 19, 'value' is already defined.
core/modules/field_ui/field_ui.js: line 328, col 5, This 'switch' should be an 'if'.
droplet’s picture

droplet CreditAttribution: droplet commented
Status: Active » Needs review
FileSize
field_ui-js.patch1.88 KB
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

Apply, still works and JSHint is happy. Thanks :)

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.