It does return drupal_bootstrap(); but drupal_bootstrap($phase = NULL, $new_phase = TRUE) so this triggers a $new_phase causing if ($new_phase) { $final_phase = $phase; } to fire, breaking the bootstrap if it's not completed. Two fixes are necessary:

  1. Do not allow drupal_bootstrap to store a phase it already passed.
  2. Change the getter to return drupal_bootstrap(NULL, FALSE);
CommentFileSizeAuthor
#1 drupal_get_bootstrap_phase_fault-1806992-1.patch1.93 KBsuperspring
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

superspring’s picture

superspring CreditAttribution: superspring commented
Assigned: sun » Unassigned
Status: Active » Needs review
FileSize
drupal_get_bootstrap_phase_fault-1806992-1.patch1.93 KB

Phase is only stored if it has not already passed and drupal_get_bootstrap is called correctly.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented

#1: drupal_get_bootstrap_phase_fault-1806992-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal_get_bootstrap_phase_fault-1806992-1.patch, failed testing.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

finalized a sentence

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Issue summary: View changes
Status: Needs work » Closed (duplicate)

This has been superseeded by #2016629: Refactor bootstrap to better utilize the kernel

chx’s picture

chx CreditAttribution: chx commented

Note that this is still an issue in D7 stalled for close to five years now at #667098: drupal_get_bootstrap_phase() is broken . Yay, core process!