JSHint editor [#1955288]

Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.
core/modules/editor/js/editor.js: line 72, col 17, Expected '===' and instead saw '=='.

Comment	File	Size	Author
#1	1955288-core-js-jshint-editor-1.patch	688 bytes	lilster66
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

lilster66 CreditAttribution: lilster66 commented 28 March 2013 at 20:01

Assigned:	Unassigned	» lilster66
Status:	Active	» Needs review

File	Size
1955288-core-js-jshint-editor-1.patch	688 bytes

Hi,

I've added a patch for this. I got the following errors:

Line 72: if (trigger == 'serialize') {

Expected '===' and instead saw '=='.

Line 109: })(jQuery, Drupal);

'jQuery' is not defined.

Line 109: })(jQuery, Drupal);

'Drupal' is not defined.

I don't think the jQuery and Drupal lines are an issue.

Comment #2

nod_

French

Lille

CreditAttribution: nod_ commented 28 March 2013 at 20:14

Status:

Needs review

» Reviewed & tested by the community

They're not indeed, check the config file in the issue linked in OP. There are a bunch of globals defined.

Tested & works well, thanks :)

Comment #3

lilster66 CreditAttribution: lilster66 commented 28 March 2013 at 20:38

Cheers :-)

I'm at a starting to contribute to Drupal event, http://www.meetup.com/a-bit-of-everything-drupal/. Thought I'd start with something straight forward :-P