Now fields and instances are config entities #1735118: Convert Field API to CMI

Let's move them to config as #1943468: Move Tags vocabulary to standard profile config

CommentFileSizeAuthor
#8 1970206-config-fields-8.patch10.01 KBswentel
#8 interdiff.txt4.18 KBswentel
#1 1970206-config-fields-1.patch8.99 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Active » Needs review
FileSize
1970206-config-fields-1.patch8.99 KB

Let's see what bot say

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

Superb CMI demo.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue tags: +Needs manual testing

Not sure we have tests for standard profile - so needs confirmation that standard profile installs fine

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Reviewed & tested by the community » Needs review

We also need to answer the "UUIDs in default config" question in #1969800: Add UUIDs to default configuration for this.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue tags: -Needs manual testing

Tested manually standard install and it works!
Actually UUIDs currently is hard requirement for field instances...

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

Actually UUIDs currently is hard requirement for field instances...

UUIDs are a hard requirement for active field instances. UUIDs are added automatically to config entities supplied as default config at installation. See the other issue, where various people have expressed concerns about shipping UUIDs in default config.

swentel’s picture

swentel CreditAttribution: swentel commented

Hmm tricky one :) Reference to uuid is the safest imo, however, we do allow in the FieldInstance class to accept an incoming field_name as well, so maybe change that for now and see what the outcome is of the other discussion.

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
interdiff.txt4.18 KB
1970206-config-fields-8.patch10.01 KB

This should work - cleaned up also in tests of field api and I could install standard profile too.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Let's get it in

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Committed 0cc0335 and pushed to 8.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +D8MI, +language-config

Woot, this will properly make them translatable as part of the configuration of the site. Thanks all!

Automatically closed -- issue fixed for 2 weeks with no activity.