Discovered in #1818570: Convert users to the new Entity Field API, patch coming in a second.

CommentFileSizeAuthor
#2 drupal-1986528-2.patch2.94 KBdawehner
#1 phpunit-fatal-get-info-1986528-1.patch849 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review
FileSize
phpunit-fatal-get-info-1986528-1.patch849 bytes

This at least fails with an actual, readable error message instead of a fatal error.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
drupal-1986528-2.patch2.94 KB

While writing a test I realized that there is another problem.

Status: Needs review » Needs work

The last submitted patch, drupal-1986528-2.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

PHP Fatal error: Call to undefined function Drupal\simpletest\Tests\debug()

:)

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented

just hit this
#1 looks like a great improvement over this:)

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

It feels like this is not really possible to test properly. Maybe #1 itself is good enough.

tsphethean’s picture

tsphethean CreditAttribution: tsphethean commented
Status: Needs work » Needs review

I just hit this too and the patch in #1 got me from fatal exception to useful error message - I'd vote for getting #1 in if possible.

vlad.leo’s picture

vlad.leo CreditAttribution: vlad.leo commented
Issue tags: -PHPUnit

#2: drupal-1986528-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal-1986528-2.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review
Issue tags: +PHPUnit

#1: phpunit-fatal-get-info-1986528-1.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Let's just get #1 in.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 8cb7ab8 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.