Noticed while testing, but not caused by: #1987124: Convert filter_admin_format_page() and filter_admin_overview() to a Controller

Updated: Comment #0

Problem/Motivation

The label disable on the action does not seem to indicate the reprocusions of disabling a format. At first time, I disabled, and then was very surprised to have the format disappear from the UI. I thought I would be able to re-enable it after disabling it. The second time I tried it, I noticed the warning message said that it would disappear from the UI and that it was permanent.

The warning message also says that content using the format will not be displayed. ... it was the thought of others that the point of calling it disable instead of delete was that the content would still be displayed, but not editable? Hm.

Proposed resolution

Call it delete.
Change the class on the delete disable to be the warning/danger red of other deletes.
Update the help text.

Remaining tasks

  • Check if the help text on the disable confirmation is accurate.
  • Research why it is called disable instead of delete.
  • Discuss.

User interface changes

Yes.

API changes

No.

  • ? (maybe do a grep for the disable help text and do a git blame to find issues that relate to why it is called disable)

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

It is called disable because it's not deleted, it stays there as a format is undeletable, you'll just never be able to get it back ;)

There have been endless and insane discussions and issues around this before the release of 7.x. Headache-causing discussions ;)

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Clarification: I'm not saying the text/descriptions/UI can't be improved, but the actual behavior of it will probably stay.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Active » Closed (works as designed)

To clarify Berdir's points: text formats may not be deleted because almost always there's >0 pieces of content using it, which must still be renderable, which means that the text formats they use must remain available. Hence text formats can only be disabled.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

#1197814: Change terminology from "disable" to "delete" when disabling a text format was marked as a duplicate of this one.

suffering drupal’s picture

suffering drupal CreditAttribution: suffering drupal commented

So being 'exact' from a programmers point of view is more important then being understood by users, right? That surely goes with my general impression of all of Drupal and it's incrowd.
My website got screwed up because I wanted to disable filtered HTML and then it turned out to be deleted.
Thank you for the exactness.
So anyway, to continue with the correct terms, since it wasn't deleted and only disabled, what's the magic formula to enable it again?

suffering drupal’s picture

suffering drupal CreditAttribution: suffering drupal commented

After lot of empty incrowd blabla, I found the answer.
As in many cases, a beginner (as I still am after ten years) who happened to run into a solution and actually SHARED it!!
https://www.drupal.org/forum/support/post-installation/2013-12-31/solved...

I found something* about changing a value somewhere : What you can do, carefully, is go into your Drupal database, to the table filter_format and change the status to 1.

Now for the next Drupal struggle!