Let's start to convert all calls to user_access() with the new AccountInterface::hasPermission() method.

Part of #2048171: [meta] Replace user_access() calls with $account->hasPermission() wherever possible.

Change records for this issue:

CommentFileSizeAuthor
#15 2062035-translation-replace-user_access-calls-14.patch797 bytesrhm5000
#12 2062035-translation-replace-user_access-calls-11.patch796 bytesrhm5000
#9 drupal-translation_replace_user_access-2062035-9.patch791 bytesphiit
#5 drupal-translation_replace_user_access-2062035-5.patch781 bytesphiit
#1 drupal-translation_replace_user_access-2062035.patch770 bytesInternetDevels
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Active » Needs review
FileSize
drupal-translation_replace_user_access-2062035.patch770 bytes

Here is the patch.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Straight

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies

phiit’s picture

phiit CreditAttribution: phiit commented
Assigned: Unassigned » phiit
phiit’s picture

phiit CreditAttribution: phiit commented
Assigned: phiit » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
drupal-translation_replace_user_access-2062035-5.patch781 bytes

Rerolled

Status: Needs review » Needs work

The last submitted patch, drupal-translation_replace_user_access-2062035-5.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue tags: +Needs reroll 
+++ b/core/modules/translation/translation.module
@@ -154,7 +154,7 @@ function translation_user_can_translate_node($node, $account = NULL) {
-  return node_access('view', $node, $account) && (user_access('translate all content', $account) || ($node->getAuthorId() == $account->id() && user_access('translate own content', $account)));
+  return node_access('view', $node, $account) && ($account->hasPermission('translate all content') || ($node->uid == $account->id() && $account->hasPermission('translate own content')));

s/$node->uid/$node->getAuthorId()

phiit’s picture

phiit CreditAttribution: phiit commented
Assigned: Unassigned » phiit
phiit’s picture

phiit CreditAttribution: phiit commented
Assigned: phiit » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
drupal-translation_replace_user_access-2062035-9.patch791 bytes

Rerolled

Status: Needs review » Needs work

The last submitted patch, drupal-translation_replace_user_access-2062035-9.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

seems HEAD moving faster

rhm5000’s picture

rhm5000 CreditAttribution: rhm5000 commented
Status: Needs work » Needs review
FileSize
2062035-translation-replace-user_access-calls-11.patch796 bytes

Rerolled

---------------
Aug 29, 2013
5429044d5edf7527b6de311e218cf42934f1a446

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Nice

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

rhm5000’s picture

rhm5000 CreditAttribution: rhm5000 commented
Status: Needs work » Needs review
FileSize
2062035-translation-replace-user_access-calls-14.patch797 bytes

Rerolled

---------------
Sep 4, 2013
dd20ffdd7a4be7596dff570c0a4900a6f50710d9

Status: Needs review » Needs work
Issue tags: -Needs reroll, -CodeSprintCIS

The last submitted patch, 2062035-translation-replace-user_access-calls-14.patch, failed testing.

LinL’s picture

LinL CreditAttribution: LinL commented
Status: Needs work » Needs review
Issue tags: +Needs reroll, +CodeSprintCIS

#15: 2062035-translation-replace-user_access-calls-14.patch queued for re-testing.

LinL’s picture

LinL CreditAttribution: LinL commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Back to RTBC.

LinL’s picture

LinL CreditAttribution: LinL commented

Removing tag (again).

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

There's a critical issue to remove translation.module from core. Shouldn't we close this in favor of that?

LinL’s picture

LinL CreditAttribution: LinL commented
Status: Reviewed & tested by the community » Closed (won't fix)

Oh yes, so closing this one in favour of: #1952062: Remove legacy translation module in favor of content translation

Thanks, Berdir.