Fatal error on article node deletion

I reproduce the error with the same conditions mentioned.

[26-Sep-2013 21:43:15 Europe/Berlin] PHP Fatal error: Call to a member function id() on a non-object in /Users/enzo/www/drupal8/core/modules/file/lib/Drupal/file/FileUsage/DatabaseFileUsageBackend.php on line 73

Hey folks

After run a debug backtrace I detect the problem is in file core/modules/file/lib/Drupal/file/Plugin/field/field_type/FileItem.php class Drupal\file\FileUsage\DatabaseFileUsageBackend and method delete.

The class don't sent the entity object properly

  /**
   * {@inheritdoc}
   */
  public function delete() {
    // @todo Move in FileField in https://drupal.org/node/2073033.
    $entity = $this->getRoot();

    // Delete all file usages within this entity.
    file_usage()->delete($this->entity, 'file', $entity->entityType(), $entity->id(), 0);
  }

So the problem is in the line $entity = $this->getRoot();

I don't know where is this method located, if someone can provide an advice about how to fix this issue, I could try.

It should probably use getEntity() now, there shouldn't be a difference between the two but you can try?

getRoot() is implemented in TypedData, but that's pretty generic code.

I'm looking at this same error since noon. I thought it was something on my machine, but apparently it's the code.

I changed the delete() method to read like this:

  public function delete() {
    // @todo Move in FileField in https://drupal.org/node/2073033.
    $entity = $this->getRoot();

    // Delete all file usages within this entity.
    
    file_usage()->delete($this->getEntity(), 'file', $entity->entityType(), $entity->id(), 0);
  }

But that triggers this error:

Fatal error: Call to undefined method Drupal\node\Entity\Node::setTemporary() in /Users/netsensei/Workspace/drupal/www/core/modules/file/lib/Drupal/file/FileUsage/FileUsageBase.php on line 36

I meant to replace getRoot() with getEntity(), not ->entity. getEntity() is badly named for reference fields :(

I tried

$entity = $this->getEntity();

and

$entity = getEntity();

Same error any glue?

I see. Seems to me that it's getting the entity to which the field is attached rather then the entities it's referencing. So, I agree: the method name definitely needs to be looked at.

Ow, sorry! :-(

Ok, ignore what I said above.

The problem is that we don't have a file reference but we try to remove file usage of it. This is also related to #1988492: Avoid having empty field items by default.

The refactoring in #2073033: Optimize file usage updates in file/image fields fixes this bug, but we need test coverage.

Easy to reproduce fatal errors are critical, so...

#2073033: Optimize file usage updates in file/image fields will fix this too. Marked that as critical and this as duplicate.

EDIT: Also added test there to prove the failure/fix.