Updated: Comment #0

Problem/Motivation

  • The ' Display author and date information.' and other node-type settings for content types are ignored when unticked
  • Steps to reproduce
  • Create a content type
  • Uncheck ' Display author and date information.'
  • Create a node of that type
  • View node in bartik theme
  • Result: Screenshot 2013-10-13 17.24.53.png

Proposed resolution

Ensure that node options and submitted variables are written as booleans to the node-type config entity.
Update node-type schema to flag these as booleans.
Update NodeType::getExportedProperties to correctly type these properties (ConfigEntityBase ignore config schemas).

Remaining tasks

Reviews

User interface changes

None

API changes

None

None

CommentFileSizeAuthor
#9 interdiff.txt1.91 KBlarowlan
#9 node-settings.4.patch7.59 KBlarowlan
#7 interdiff.txt4.13 KBlarowlan
#7 node-settings.3.patch6.63 KBlarowlan
#3 interdiff.txt1.18 KBlarowlan
#3 node-settings.2.patch2.51 KBlarowlan
node-settings.pass_.patch2.38 KBlarowlan
node-settings.fail_.patch762 byteslarowlan
Screenshot 2013-10-13 17.24.53.png31.41 KBlarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Priority: Critical » Major

whoops

Status: Needs review » Needs work

The last submitted patch, node-settings.pass_.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
FileSize
node-settings.2.patch2.51 KB
interdiff.txt1.18 KB

Node options not always available, meh

Status: Needs review » Needs work

The last submitted patch, node-settings.2.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

hot diggity dog, more fails in head because publish flag always defaults to yep.

kattekrab’s picture

kattekrab CreditAttribution: kattekrab commented

Yep I stumbled on this bug too.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
FileSize
node-settings.3.patch6.63 KB
interdiff.txt4.13 KB

Some crazy stuff going on here.
Since these need to be booleans in the schema/config file, we need to massage the default values in the form controller.
As well as update the default node types in standard profile.
And the node default values.

Status: Needs review » Needs work

The last submitted patch, node-settings.3.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
FileSize
node-settings.4.patch7.59 KB
interdiff.txt1.91 KB

how about this?

Status: Needs review » Needs work

The last submitted patch, node-settings.4.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

This reads like a dupe of #2053461: Node type settings such as published state, promoted state, create revision and author information cannot be turned off, but the patch is completely different. Maybe they're both needed?
Also is this really against Bartik?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Component: Bartik theme » node.module

Whoops

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Title: Node type settings such as published state, promoted state, author information ignored when unticked » Node type settings such as published state, promoted state, author information cannot be turned off
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Closed (duplicate)

Teaming up in #2053461: Node type settings such as published state, promoted state, create revision and author information cannot be turned off