jQuery Cookie library is no longer included in jQuery UI

A few clarifications:

The cookie plugin was never part of jQuery UI. It was included as an external purely for the purpose of creating a demo to show how to use the cookie plugin with the jQuery UI tabs plugin.

The cookie plugin was copied into the external directory as is. jQuery UI never modifies external code, so it's impossible for the API to have been different.

Any file size difference (and API difference for that matter) is due to the fact that you're comparing the current version of the plugin to a version from 2010.

I'd go with:

Proposed solution D

1. Drop $.cookie() altogether and stop using cookies to store anon username and mail for comments and contact form. localStorage does that.

The only change would be that the information is saved regardless of the form being successfully submitted or not (we only save the info on form submit but if there is a validation error, the infos would still be saved).

There's no functional bug here so re-classifying. This will need a library rename (or completely killing it) so agreed on critical though.

+1 for solution D.

Or even proposition E: remove the whole user info thing and let browsers handle it. They all remember usernames in forms now. Unless you disabled the functionality which means saving the infos in a cookie probably isn't what you'd want.

patch for solution E

Missed a few spots

I think it is worth acknowledging that modern browsers all support window.localStorage, and that is a simple enough interface to store data on the client side.

Drupal 8 supports IE9+, and local storage was introduced in IE8.

I think a compromise between nod_ and sun's solutions is to replace all references to $.cookie() with localStorage, rather than remove the functionality all together.

In theory I agree, we can ship the lib or something but what we use them for really doesn't need to be cookies.

**** Cross post message ****
I find an issue with the jquery-joyride library while creating a patch that replace cookie by localStorage for the auto fill.

We use the 2.0.3 version of jquery-joyride that rely on jquery.cookie.

Seems that the last version (2.1) can use localStorage as see here : https://github.com/zurb/joyride

This issue already talk about the joyride version : https://drupal.org/node/2027623
If joyride 2.1 works I propose to update to this version to allow the full removal of jquery.cookie.

BTW, i see that jquery.form.js also have jquery.cookie as a dependency in the core.libraries.yml but i can't find any reference of that on jquery.form's website or code.
****

Since we keep jquery.cookie, there is no issue with jquery-joyride and I hope I can soon propose a patch for the localStorage autofill feature.

Moving revisit before beta tag from #1203526: jquery.cookie version update

1. Launched a patched sandbox on Simplytest.me.
2. Installed standard profile.
3. Created an article.
4. Add the "Post comments" and "Skip comment approval" permissions to anonymous.
5. Open another browser session, post a comment as anonymous selecting "xxxx" as username.
6. Checked that there is a cookie

The cookie:

 "[
{
    "domain": "sfa3b2f23c5a5028.s2.simplytest.me",
    "expirationDate": 1429046231.278518,
    "hostOnly": true,
    "httpOnly": false,
    "name": "Drupal.visitor.name",
    "path": "/",
    "secure": false,
    "session": false,
    "storeId": "1",
    "value": "xxxx",
    "id": 1
}
]

But...
form.js was not included in the form, so there is no completion. jquery.cookie.js was neither in the page.
We need to create bug reports for that if there aren't yet.

But as we only want to upgrade the library in this issue, I guess I can RTBC it.

Committed/pushed to 8.x, thanks!

Awesome! Created #2241447: [Regression] Autocompletion for anonymous data in forms for #24.

Now this is fixed we don't need to pay any more special attention to this library before beta.