Problem/Motivation

Once #1857256: Convert the taxonomy listing and feed at /taxonomy/term/%term to Views is in, format_rss_item and format_rss_channel aren't used anymore in core. On top of that we have a good feed library, so we don't need that any longer.

Proposed resolution

kill it!

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#7 kill-format_rss.patch1.84 KBjibran
#3 kill-format_rss_*.patch1.79 KBjibran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Title: Kill format_rss_item and format_rss_channel » Remove format_rss_item() and format_rss_channel()
Issue tags: +@deprecated
sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Active » Postponed
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
FileSize
kill-format_rss_*.patch1.79 KB

Killer patch

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Priority: Major » Normal

100% dead code -- there are no references to these functions anywhere else in core once #1857256: Convert the taxonomy listing and feed at /taxonomy/term/%term to Views is in. So this can be RTBC as soon as that lands.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Postponed » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: kill-format_rss_*.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review
FileSize
kill-format_rss.patch1.84 KB

Rerolled.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Awesome

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

We need to update https://www.drupal.org/node/2084727 with the removed functions and link it to this issue.

Committed b33a215 and pushed to 8.0.x. Thanks!

  • alexpott committed b33a215 on 8.0.x 
    Issue #2251111 by jibran | dawehner: Remove format_rss_item() and...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

I updated the CR.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.