Blocks should be added to the page via an HtmlFragmentRenderer [#2295363]

Problem/Motivation

In #2286357: Introduce Display Variants, use for the block rendering flow, we adjusted block_page_build() to add blocks from the full page variant.

Proposed resolution

Because #2292733: [meta] Introduce Display objects might eventually mean taking over the entire rendering process, we should start by using an alternate HtmlFragmentRenderer to handle the blocks.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Comment	File	Size	Author
#10	interdiff.txt	2.4 KB	tim.plunkett
#10	2295363-block-10.patch	6.56 KB	tim.plunkett
#8	2295363-block-8.patch	4.16 KB	tim.plunkett
#4	interdiff-a.txt	820 bytes	tim.plunkett
#4	interdiff-b.txt	1.44 KB	tim.plunkett
#4	block-2295363-4a.patch	4.14 KB	tim.plunkett
#4	block-2295363-4b.patch	4.49 KB	tim.plunkett
#1	block-2295363-1.patch	4.06 KB	tim.plunkett

Comments

Comment #1

tim.plunkett

he/him

English

Philadelphia

commented 30 June 2014 at 20:11

Status:

Active

» Needs review

Status	File	Size
new	block-2295363-1.patch	4.06 KB

Comment #2

tim.plunkett

he/him

English

Philadelphia

commented 30 June 2014 at 20:16

Note, I chose to continue extending DefaultHtmlFragmentRenderer because we're only adding in the blocks. Eventually we could just implement HtmlFragmentRendererInterface directly.
However, if I tried to do that, I'd be blocked by #2295367: BatchController should not rely on DefaultHtmlFragmentRenderer directly.

Comment #3

30 June 2014 at 21:06

Status:

Needs review

» Needs work

The last submitted patch, 1: block-2295363-1.patch, failed testing.

Comment #4

tim.plunkett

he/him

English

Philadelphia

commented 30 June 2014 at 22:24

Status:

Needs work

» Needs review

Status	File	Size
new	block-2295363-4b.patch	4.49 KB
new	block-2295363-4a.patch	4.14 KB
new	interdiff-b.txt	1.44 KB
new	interdiff-a.txt	820 bytes

Well, that was surprising.
We need to contend with the main content fallback code. Here are two options.

Comment #5

30 June 2014 at 22:40

Status:

Needs review

» Needs work

The last submitted patch, 4: block-2295363-4a.patch, failed testing.

Comment #6

30 June 2014 at 22:54

The last submitted patch, 4: block-2295363-4b.patch, failed testing.

Comment #7

eclipsegc commented 1 July 2014 at 16:25

I'm working on a patch for this that moves drupal_prepare_page() into DefaultHtmlFragmentRender::preparePage() and subsequently results in being able to remove both drupal_prepare_page and drupal_render_page. I'm still debating this approach, but I think it makes sense the more I play with it. It's just a matter of getting all the parts in the right places and updating the code that manually references those things already... which isn't actually all that much code. (I was surprised)

I'll see if I can get something up soonish.

Eclipse