Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
While reviewing #1821454: [theme_table] 'active' class added to wrong column, I detected that the twig variable cell.active_table_sort
used in table.html.twig
is affected by a combination of defects:
- The
active
class is set bytablesort_header()
. - The
cell.active_table_sort
twig variable is never set for header cells. However, in the twig template it is only ever checked when processing the header section (for cell in header
). - In contrast the
cell.active_table_sort
is set for cells in rows and footer, but in the twig template it is never checked when processing rows or footer section
Proposed resolution
Either remove cell.active_table_sort
or fix it.
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#5 | 2364413-5.patch | 2.59 KB | rpayanm |
Comments
Comment #1
znerol CreditAttribution: znerol commentedAttached is a patch which removes
cell.active_table_sort
completely. Note that this has no effect on the markup.Comment #2
znerol CreditAttribution: znerol commentedComment #3
znerol CreditAttribution: znerol commentedComment #4
jhedstromComment #5
rpayanmComment #6
akalata CreditAttribution: akalata commentedComment #7
mgiffordPatch no longer applies.
Comment #21
quietone CreditAttribution: quietone as a volunteer commentedThere has been activity here for 8 years. So, is this problem still relevant?
Since we need more information to move forward with this issue, I am setting the status to Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Comment #22
quietone CreditAttribution: quietone as a volunteer commented