Lots of tests still enable entity.module, that has been removed a while ago.

CommentFileSizeAuthor
#1 2372477-test_entity_module-1.patch17.79 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Needs review
FileSize
2372477-test_entity_module-1.patch17.79 KB

patch

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

Looks good!

amateescu’s picture

amateescu CreditAttribution: amateescu commented

<rant>Wouldn't it be better to leave these in place for the next time we decide to re-re-reintroduce the entity module?</rant>

Otherwise +1 from me as well.

yched’s picture

yched CreditAttribution: yched commented

@amateescu : lol

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Nice clean-up, +1 to add tests or just throw exception when test provides none existing module

PS: @amateescu are you going to maintain :)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

#3 wins comment of the month.

Committed/pushed to 8.0.x, thanks!

Would be good to see that follow-up to throw an exception when tests are enabling missing modules.

  • catch committed 4dc03e7 on 8.0.x 
    Issue #2372477 by yched: Fixed Lots of tests still enable entity.module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.