Replace all drupal_render calls with the service, and inject it, if possible.

@pjonckiere I'm not sure a meta as I hope we can do it all here, but maybe... Tagged with Twig so it shows up on our http://drupaltwig.org/

Also the first step is to avoid calling it all together preventing early rendering, then inject, then procedural service call.

I've updated the IS and added a script to help find them all.

@pjonckiere is this similar to what you used?

List:

ack 'drupal_render\(' core

Count

ack 'drupal_render\(' core | wc -l

A few will be cleaned up by means of #2348381: [META-0 theme functions left] Convert/refactor core theme functions, and lots are tests.

It may be worth injecting the renderer onto WebTestBase for all the tests to call $this->render();

@joelpittet in #3: The render thingy exists today as a trait, see #2257519: Move content assertion methods into a trait, so DUTB can consume it, too (\Drupal\simpletest\AssertContentTrait), available in WebTestBase and KernelTestBase.

If we try to evaluate these and remove early rendering, this is probably going to stall out. If we want to replace the drupal_render() calls we should make it scriptable. See also "how to meta your metas".

We could split this up the way we did in #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

I think that the need to inject the service in some cases but not in others automatically makes this a meta because it isn't scriptable. A human has to review each replacement.

#2471913: Replace drupal_render calls in core/modules/simpletest

Please make sure new child issues are set to "Active" unless there is a patch posted.

Should we be replacing drupal_render_root() as well?

#2473393: Replace drupal_render calls in core/includes

#25: drupal_render_root() is replaced with $renderer->renderRoot().

How was I not yet following this issue?!?

Wim: The same reason I wasn't. Welcome to my life. :-) (subscribe!)

Thanks everyone for your work here. drupal_render() was not deprecated before the beta, and is marked for removal by 9.0.0. Per the allowed beta changes policy, only the removal of functions deprecated for removal 8.0.0 is a prioritized change. So the normal task of removing uses of drupal_render() isn't in scope during this phase of the release cycle, since we have to keep drupal_render() around until 9.x anyway.

It would be okay to resume simple conversions that preserve BC after 8.0.0, so postponing this to 8.1.x.

It would be great to have everyone's help instead in #2348381: [META-0 theme functions left] Convert/refactor core theme functions and #2205673: [META] Remove all @deprecated functions marked "remove before 8.0". Also see the other open Twig issues:
https://www.drupal.org/project/issues/search/drupal?project_issue_follow...

Agreed, thanks @xjm.

Also, discussed with @alexpott and @webchick. When we do convert these, we should do it in a single patch rather than many small issues since it's actually a single conceptual change. So let's not file any additional child issues, and re-scope this to not be a meta.

Tagging DX because it'd be better for DX if zero calls to drupal_render() remained: then contrib/custom code will be less tempted to call drupal_render(), thus encouraging better code, thus leading to a more consistent overall (core + contrib + custom) D8 code base, thus a better DX.

We can still justify some of those conversions in D8 with performance however.

- If something is called on every page and uses drupal_render() within an injectable service => convert it
- If something is not called on every page but just on some obscure admin page or within some legacy function => leave it

So we should split at least one performance issue for conversions that have a performance impact.

(and yes the indirection of drupal_render -> \Drupal::service('renderer') -> $container->get('renderer') -> $container->getRenderer() -> render() does matter.)

Removing the novice tags as it's not good to have these on issues that are targeted for 8.1.x or that do not have consensus in one way or another.

If there is an actual non-negligible performance gain, let's demonstrate that where it happens and file related issues. Thanks!

Edit: Agreed that it is better DX for sure; just that alone isn't enough to justify a change at this point.

Are you guys aware that render - both service and old render function is completly broken? #2474865: drupal_render() and service no longer attach

Updating issue summary.

Some items already underway:

#2529438: Inject renderer service into ThemeManager, disuse drupal_render()
#2017549: Remove usage of drupal_render and theme functions in Views/Views UI
#2428925: Create a trait to add in the renderer service

Oops missed these.

#2704871: Replace usages of deprecated method drupal_render()

drupal_render() happened in #2704871: Replace usages of deprecated method drupal_render(), drupal_render_root() will happen in #2818677: Replace usages of deprecated method drupal_render_root()