Simpletest install requirements double escaped

The error text has been changed from ./sites/simpletest to sites/simpletest. While this may be a change for the better, let's keep it out of scope of this issue and fix the double escaping first.

I have been looking through the User interface standards but I could not find a reference on how to display paths/files. The meta issue suggests using a Twig inline template if you want to maintain markup, as documented here: https://www.drupal.org/node/2311123

I'm fine with dropping the <code> tag in favor of the <em> tag, but I'm not sure how it affects the scope of this issue. I'll leave this for someone else to review.

I was not able to replicate the problem. Everytime I am doing chmod 444 -R sites/simpletest, after I open a new page the permission gets back to 777

@rocketeerbkw It appears there is an issue with the line endings in your patch. Can you check if your git configuration matches the recommended git settings: https://www.drupal.org/documentation/git/configure

double post on accident...

seems to be working for me.

- nick

+++ b/core/modules/simpletest/simpletest.install
@@ -71,8 +71,8 @@ function simpletest_requirements($phase) {
-      'description' => t('The testing framework requires the !sites-simpletest directory to exist and be writable in order to run tests.', array(
-        '!sites-simpletest' => './' . String::checkPlain($site_directory) . '',
+      'description' => t('The testing framework requires the ./!sites-simpletest directory to exist and be writable in order to run tests.', array(
+        '!sites-simpletest' => String::checkPlain($site_directory),

@@ -81,8 +81,8 @@ function simpletest_requirements($phase) {
-      'description' => t('The file !file does not exist and could not be created automatically, which poses a security risk. Ensure that the directory is writable.', array(
-        '!file' => './' . String::checkPlain($site_directory) . '/.htaccess',
+      'description' => t('The file ./!file/.htaccess does not exist and could not be created automatically, which poses a security risk. Ensure that the directory is writable.', array(
+        '!file' => String::checkPlain($site_directory),

Convert to an @ and remove the String::checkPlain() would work best. This is fine because nothing inside the code tags is translated.

Something like:

      'description' => t('The file @file does not exist and could not be created automatically, which poses a security risk. Ensure that the directory is writable.', array(
        '@file' => './' . $site_directory . '/.htaccess',

Actually the file name is not code so it should not be wrapped in code tags anyway. It should be wrapped in placeholders.

This would then match system_requirements()

      $conf_errors[] = t("The directory %file is not protected from modifications and poses a security risk. You must change the directory's permissions to be non-writable.", array('%file' => $conf_path));

Plus adding the ./ is weird and unnecessary.

Both #1 or #10 work for me

Can someone re-upload the patch in 1 so that the correct rtbc patch is the latest in the issue?

This is because testbot retests the rtbc queue - only the latest patches.

Committed 397f4a6 and pushed to 8.0.x. Thanks!