xmlrpc.inc.test is not up to date with the current simpletest framework, and running it results in 0 passes, 0 failed, 0 errors. The test starts with:

if (!$this->drupalModuleEnable('simpletest_xmlrpc')) {
  return FALSE;
}

DrupalWebTestCase::drupalModuleEnable() doesn't have a return value, so nothing gets executed.

CommentFileSizeAuthor
#1 drupalModuleEnableCleanup.patch2.23 KBboombatower

Comments

boombatower’s picture

boombatower commented
Component: base system » simpletest.module
Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new drupalModuleEnableCleanup.patch2.23 KB

Fixed drupalModuleEnable issue and made small cleanup changes to XMLRPC test.

dries’s picture

dries commented

Shouldn't "XML-RPC validator1" be "XML-RPC validator1" too?

Can we make these tests run without simpletest_xmlrpc.module?

chx’s picture

chx commented

Hardly. You need a module which defines hook_xmlrpc.

floretan’s picture

floretan commented

I'm sure there are other hooks that would need a sample implementation to be tested efficiently. Rather than having simpletest_xmlrpc.module, wouldn't it make sense to have a simpletest_hooks.modules that would implement hooks for testing purposes?

boombatower’s picture

boombatower commented

Patch #1 doesn't conflict with removing the simpletest_xmlrpc.module. The functions are flawed and need the patch. The other portion just cleans up the xmlrpc.test.

The patch can be committed and the issues with hooks can be further discussed. If necessary I can create a separate issue for the patch, but it fixes a bug and that should be fixed.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. I fixed the typo myself.

boombatower’s picture

boombatower commented

By comment #2 I wasn't sure what you were talking about since the two strings in quotes are the same. After looking at the commit I see the issue. I'm not sure why it was suffixed with a 1.

This was one of the many oddities that I tried to cleanup, but can't get them all. :)

boombatower’s picture

boombatower commented
Component: simpletest.module » tests

Change component is relation to http://drupal.org/node/253744.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.