UserRegistrationTest still tests for a details element with account information. But that simply doesn't exist anymore.

See #2120395-7: Useless test in UserRegistrationTest.php for a screenshot.

CommentFileSizeAuthor
#3 test-outdated-account-information-2853671-3.patch744 bytesjacob.embree
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Patch (to be ported) » Active
jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commented
Status: Active » Needs review
FileSize
test-outdated-account-information-2853671-3.patch744 bytes

Status: Needs review » Needs work

The last submitted patch, 3: test-outdated-account-information-2853671-3.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Needs work » Needs review

Random fail

poker10’s picture

poker10 CreditAttribution: poker10 at ActivIT s.r.o. commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Pending Drupal 7 commit

Thanks for working on this! The patch is still green and looks good.

The "Account information" fieldset was removed in this commit: https://git.drupalcode.org/project/drupal/-/commit/076002833cbb16e9214b3... (see this issue: #601912: UX: Remove account fieldset on user account form). I think we can safely remove this code.

It was also removed in D8+ here: #2120395: Useless test in UserRegistrationTest.php

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented

The patch still applies to the 7.x branch.

  • mcdruid committed 444c26dd on 7.x 
    Issue #2853671 by jacob.embree, dpi, poker10, apaderno: [D7] Useless...
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

Less code is more good :)

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.