Need to test one line e-mail handling in mail.inc

CommentFileSizeAuthor
#7 mail_test.patch2.18 KBp.brouwers
#3 mail_test.patch2.12 KBp.brouwers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nielsvm’s picture

nielsvm CreditAttribution: nielsvm commented
Assigned: Unassigned » nielsvm

Assigned!

nielsvm’s picture

nielsvm CreditAttribution: nielsvm commented
Assigned: nielsvm » Unassigned

Sorry, withdrew myself. Too busy for now. If I've got more time I will try to pick up more tests.

p.brouwers’s picture

p.brouwers CreditAttribution: p.brouwers commented
Component: tests » base system
Assigned: Unassigned » p.brouwers
Status: Active » Needs review
FileSize
mail_test.patch2.12 KB

made a small test for it

dmitrig01’s picture

dmitrig01 CreditAttribution: dmitrig01 commented
Status: Needs review » Needs work 
+    $this->assertTrue(strpos($message['body'], '\n')===FALSE, t('Testing a one line mail'));

Need spaces on either side of ===

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
CreditAttribution: mr.baileys commented

Sorry for my ignorance, but why should there be a specific test for single-line e-mails (what specifically should be tested)?

Pending patch has some code style errors, and with the advent of #296001: Capture e-mails sent during tests and add e-mail assertions / API it can probably be simplified a lot.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Category: bug » task
Priority: Critical » Normal

Moving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.

p.brouwers’s picture

p.brouwers CreditAttribution: p.brouwers commented
Status: Needs work » Needs review
FileSize
mail_test.patch2.18 KB

Changed the patch to use the new email-capture system and fixed the code style

Status: Needs review » Needs work

The last submitted patch failed testing.