Convert menu_link_content, menu_ui module hook_help() to topic(s)

@Rangaswini -- are you still planning to work on this issue? If so, please comment here. If not, please unassign so that someone else can work on it. Thanks!

This is a good start, thanks!

A few things that need to be done to improve the patch -- see the help topics standards page for reference: https://www.drupal.org/docs/develop/documenting-your-project/help-topic-...

a) Steps should be OL lists not UL lists on task topics.

b) A few of the topics are not following our heading structure, like missing the heading for Steps.

c) grammar proofreading in all topics. There are a lot of missing articles (a/an/the).

d) core.menus.html.twig -- how about putting the "What is a menu?" section first? Also when answering "What is a menu link?", answer that question, not "What is the Menu Link module?" (which is what the answer looks like). We don't want module overview topics.

e) Some of the navigation instructions follow our conventions, and some of them don't. See standards page.

f) menu_ui.delete.html.twig -- steps seem to be about adding a menu, not deleting it?

Needs work is the correct status for an issue that has a patch that needs to be updated.

I will wait to review this patch until the tests pass... Thanks!

Just a quick look -- this patch has some grammar problems. Also some HTML problems, such as in the top-level topic, under Additional Resources there is a UL list but the item in the list is not in an LI tag. Also not all the topics follow the templates/standards in Standards for Help Topics.

I don't have time for a full review right now and there may be other problems, so I'm just setting it back to Needs Work.

Thanks for the patches! And sorry for the delay reviewing. I had some time today, so I looked at the most recent patch (#20). I did not apply the patch, just looked at the text. It still needs some work:

1. core.menus.html.twig
   • Title should be sentence case not proper case (second word not capitalized).
   • What is custom menu link?
     This heading, if we keep it, should be written "What is a custom menu link?". However, as written, the text in this section seems to be describing the functionality of the Custom Menu Links module, not giving us information about what a custom menu link is. I am getting kind of tired of saying this in reviews, but please go read the help topic guidelines https://www.drupal.org/docs/develop/documenting-your-project/help-topic-... before making or revising patches. We do not want to have text that describes modules. We want to have text in our topics that tells you how to do things with Drupal (task-oriented), or that give overviews and background information that you would need to perform these tasks. So, this section needs a rewrite, or maybe the small amount of information that is actually needed to describe custom menu links should be added to the previous section? So that section might just have a few sentences saying that the links in the menu can either be provided by modules, or can be custom (and explain what a custom link is).
   • This topic is missing the required "Overview of managing menus" section for an Overview topic (see help topic standards)
2. menu_ui.content_type_configuration.html.twig
   • Goal section text should start with "Configure" not "Configuring". Again, please read the help topic standards and look at the example there and other help topics as models. Goal should also have an additional sentence with more information about what you are configuring, which is setting up which menu items each type of content can be placed in when adding/editing content.
   • Navigation is wrong. Should not be going to Add content type.
   • Choose <em>Menu settings</em> tab. Select the required menus. We should word this as "Under Menu settings, select the menus that you would like to have content items placed in", or something like that.
   • Last sentence should be something like "Optionally, select a parent menu item, if the content items should not be placed at the top level of the menu." or something similar.
   • Missing an instruction to click Save or Save configuration or whatever the button is called.
3. Other topics need similar work, as well as grammar/punctuation. Really, someone needs to read them through carefully, make sure they are worded consistently with other topics, make sure there are not grammar/punctuation errors, and make a new patch. When I have time, I will work on a new patch if someone else doesn't do it first... but I think my time would be better spent making this patch rather than explaining all the necessary changes in an issue comment.
4. I'm also not sure that the division into topics makes perfect sense... do we need whole topic on how to expand a menu item, for instance, or should we just add a "What settings do menus have?" heading to the overview topic, and explain this and other settings on menus and menu items? That might be more useful.

Here is a new patch. Pretty much everything changed, so I did not make an interdiff file (not useful).

Thanks very much for the careful review! The changes you have suggested look very good to me. I think that since you have given this a careful review, we can mark the latest patch RTBC on the strength of that review with your two small changes.

Good point, we should standardize on what it says in the UI, which I is "link". We should also verify that this is consistent in the UI, but that would be a separate issue if it's not consistent.

Well, the Menu UI module uses a mix of terms -- it usually says "menu link" or "link", but it occasionally says item. I created an issue for thatL:
#3158562: Consistently refer to "menu links" as that, not "menu items", in the UI

I will assume that should be fixed eventually, and proceed with this fix. Note that some UI text is referred to directly in the help, and so the word "item" still appears in the help. Here's a new patch.