Problem/Motivation

Follow up of 3138766: Fix "Don't" relevant typos in core

Example:
core/modules/migrate_drupal_ui/src/Form/OverviewForm.php
':url' => 'https://www.drupal.org/docs/8/upgrade/preparing-an-upgrade#dont_create_content',

@xjm reported:

I updated this URL fragment in the handbook:
https://www.drupal.org/docs/upgrading-drupal/preparing-a-site-for-upgrade-to-drupal-8#do_not_create_content

I left an <a> tag with the old name/ID in place also, so that anything else that had the old link would not be broken. Confirmed the link works as expected.

Updating that URL is also technically back portable since it's one of the placeholder values of the string, rather than part of the first argument of
t(), so it's not a string break.

Proposed resolution

':url' => 'https://www.drupal.org/docs/8/upgrade/preparing-an-upgrade#do_not_create_content',

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3143724-5.patch1.36 KBsja112
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sja112 created an issue. See original summary.

sja112’s picture

sja112’s picture

Title: Fix "dont" relevant typos in URL string » Fix relevant typos in URL string
Issue summary: View changes
sja112’s picture

Title: Fix relevant typos in URL string » Fix 'dnot' relevant typos in URL string
Assigned: Unassigned » sja112
Issue summary: View changes
sja112’s picture

Assigned: sja112 » Unassigned
Status: Active » Needs review
FileSize
1.36 KB
sja112’s picture

Title: Fix 'dnot' relevant typos in URL string » Fix 'dont' relevant typos in URL string
longwave’s picture

Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 3143724-5.patch, failed testing. View results

longwave’s picture

Status: Needs work » Reviewed & tested by the community
xjm’s picture

Title: Fix 'dont' relevant typos in URL string » Fix 'dont' in a Drupal.org URL fragment

I debated whether to merge this back into the other issue or not, but given that it's a change to external code, I decided to keep it separate.

  • xjm committed f1ce5f7 on 9.1.x
    Issue #3143724 by sja112, xjm: Fix 'dont' in a Drupal.org URL fragment
    
xjm’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.