Problem/Motivation

Drupal.ckeditor5.openDialog() implements a loading animation. However, that isn't styled, and is only visible on the very bottom of the page.

Proposed resolution

Implement proper loading animation for when dialog is being opened.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#18 3248448-18-9.3.x.patch2.69 KBWim Leers
#9 3248448-9-d10.patch2.42 KBlauriii
Screen Shot 2021-11-09 at 14.14.42.png55.29 KBlauriii

Issue fork drupal-3248448

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms

CKEditor 4 has something nice for this: #1879120-61: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms:

I think matching that would be fine?

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented

This would work for Seven, but Claro has its own designs for throbbers: https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/Drupal-Design-system...

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Project: CKEditor 5 » Drupal core
Version: 1.0.x-dev » 9.3.x-dev
Component: Code » ckeditor5.module
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

In the current implementation, this only affects the drupalMedia plugin.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

hooroomoo made their first commit to this issue’s fork.

hooroomoo opened merge request !1714

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Active » Reviewed & tested by the community
FileSize
3248448-9-d10.patch2.42 KB

Looks great! Tested manually with both, Seven and Claro and the fullscreen throbber is showing up as expected. Here's also a Drupal 10 version of the MR.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
CreditAttribution: ckrina at Lullabot commented

Testing this I've found a small bug for the throbber in Firefox, not related to this issue. I've opened a follow-up to address it: #3260576: Throbber on Firebox renders different.

  • ckrina committed 275f8b5 on 10.0.x 
    Issue #3248448 by hooroomoo, lauriii, Wim Leers: Dialog loading text is...

  • ckrina committed 02f32df on 9.4.x 
    Issue #3248448 by hooroomoo, lauriii, Wim Leers: Dialog loading text is...
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
CreditAttribution: ckrina at Lullabot commented
Status: Reviewed & tested by the community » Fixed

Committed 275f8b5 and pushed to 10.0.x. Also committed the 9.x patch to 9.4.x. Thanks!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#3260576: Throbber on Firebox renders different

Woah, that was really fast!

lauriii closed merge request !1714

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Closed (fixed) » Needs work

Re-opening for 9.3.x backport.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Needs review
Issue tags: +JavaScript
FileSize
3248448-18-9.3.x.patch2.69 KB

Patch from local chery-pick.

  • lauriii committed 77535b7 on 9.3.x 
    Issue #3248448 by hooroomoo, lauriii, Wim Leers: Dialog loading text is...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Needs review » Fixed

Committed 77535b7 and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.