Problem/Motivation

Per #3232550-11: Improve messaging about Internet Explorer 11.

This should wait until after #3232550: Improve messaging about Internet Explorer 11.

Steps to reproduce

N/A

Proposed resolution

N/A

Remaining tasks

N/A

User interface changes

No more IE11 warning.

API changes

None.

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#19 3261585-18.patch22.33 KBlongwave
#15 interdiff.3261585.13-15.txt511 byteslongwave
#15 3261585-15.patch22.68 KBlongwave
#13 reroll_diff_3261585_11-13.txt5.04 KBankithashetty
#13 3261585-13.patch22.42 KBankithashetty
#11 3261585-11.patch23.2 KBlongwave
#8 3261585-8.patch22.93 KBlongwave
#3 3261585-3.patch22.59 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: [PP-1] Remove IE11 warning for CKEditor 5 in Drupal 10, since Drupal 10 does not support IE anyway » Remove IE11 warning for CKEditor 5 in Drupal 10, since Drupal 10 does not support IE anyway
Status: Postponed » Active

#3232550: Improve messaging about Internet Explorer 11 landed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Active » Needs review
FileSize
3261585-3.patch22.59 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Parent issue: » #3252084: [meta] Remove support for IE11
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

That looks … very thorough :D

This is RTBC IMHO.

But … I'd rather not get this committed immediately, because it will likely make the work on CKEditor 5 even more painful. We already need to target 3 branches, and frequently need to provide a different patch for the D10 branch. This will make that necessary more often.

As soon as this is green, I'm marking this "postponed" again and will RTBC in ~1.5 month.

Thanks so much, @longwave!

Status: Needs review » Needs work

The last submitted patch, 3: 3261585-3.patch, failed testing. View results

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#3260032: CKEditor 5 adds ie11.user.warnings library to every page, triggering a FOUC even for anonymous users

3 weeks later, many things that were in progress have landed.

I now think we can totally do this now, especially because it makes it clearer that #3260032: CKEditor 5 adds ie11.user.warnings library to every page, triggering a FOUC even for anonymous users only impacts Drupal 9.3 and 9.4.

Do you want to reroll and get this to green, @longwave? :)

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Needs work » Needs review
FileSize
3261585-8.patch22.93 KB

Rerolled, also removed a bit too much in ckeditor5_library_info_alter().

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

That looks perfect to me :)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs another re-roll.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll
FileSize
3261585-11.patch23.2 KB

#3266310: IE11 user warning has ungraceful failures landed in 10.0.x which updated ie11.user.warnings.es6.js and .js - both files are outright removed here so back to RTBC.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs another re-roll...

ankithashetty’s picture

ankithashetty
Location Karnataka, India
CreditAttribution: ankithashetty as a volunteer and at Specbee commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
3261585-13.patch22.42 KB
reroll_diff_3261585_11-13.txt5.04 KB

Here is a rerolled patch, thanks!

Status: Needs review » Needs work

The last submitted patch, 13: 3261585-13.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Needs review
FileSize
3261585-15.patch22.68 KB
interdiff.3261585.13-15.txt511 bytes

Missed one line in ckeditor5.libraries.yml.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

Looks just as good as when I RTBC'd it in #9 🤓

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Sorry, @longwave 😬

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll
FileSize
3261585-18.patch22.33 KB

Clashed with #3270108: Editor does not load when using Edge + WHCM, rerolled and back to RTBC.

  • catch committed ffcf3e6 on 10.0.x 
    Issue #3261585 by longwave, ankithashetty, Wim Leers: Remove IE11...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Rare example of a js patch I'm comfortable committing ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.