Problem/Motivation

\Drupal\Core\Test\AssertMailTrait::verboseEmail() is deprecated in Drupal 9.2.
We should remove it in 10.

Steps to reproduce

N/A

Proposed resolution

Remove \Drupal\Core\Test\AssertMailTrait::verboseEmail()

Remaining tasks

All the things.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#2 3274016-2_remove_AssertMailTrait_verboseEmail.patch1.18 KBEli-T
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Eli-T created an issue. See original summary.

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T commented
Status: Active » Needs review
FileSize
3274016-2_remove_AssertMailTrait_verboseEmail.patch1.18 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Issue tags: +ddd2022
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented

Addressed also by #3261266: Remove deprecated code from the testing framework (base classes, listeners, etc) from a broader perspective

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

@mondrake I would like to remove this function before getting a reroll on #3260928: Move more PHPStan global ignore patterns to baseline - this code is a bit different to the rest in #3261266: Remove deprecated code from the testing framework (base classes, listeners, etc) because it is actually broken code. It's been broken for ages and adds a lot of noise to PHPStan.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

Tagged for removal, time for it to go.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Parent issue: » #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed 2021dee and pushed to 10.0.x. Thanks!

  • alexpott committed 2021dee on 10.0.x 
    Issue #3274016 by Eli-T, longwave, mondrake: Remove \Drupal\Core\Test\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.