Move RDF-related tests to RDF module

Applied the MR. I ran the failing test locally and it passed. Then I searched for rdf in tests while specifically ignoring migration related tests.

$ grep -riw -I rdf core | grep -v core/modules/rdf | grep -v migrate | grep Test.php | awk -F: '{print $1}' | grep -v grep | sort -u | nl
     1  core/modules/hal/tests/src/Functional/rdf/RdfMappingHalJsonAnonTest.php
     2  core/modules/hal/tests/src/Functional/rdf/RdfMappingHalJsonBasicAuthTest.php
     3  core/modules/hal/tests/src/Functional/rdf/RdfMappingHalJsonCookieTest.php
     4  core/modules/system/tests/src/Functional/Common/NoJavaScriptAnonymousTest.php
     5  core/modules/system/tests/src/Functional/Entity/EntityViewControllerTest.php
     6  core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php
     7  core/tests/Drupal/KernelTests/Core/Theme/ConfirmClassyCopiesTest.php

What about these tests? Is there anything to move?

Re #5

I think the 3 HAL test can be deleted when we remove RDF module. It seems super unlikely anyone is ever reading RDF mappings via HAL, given that both those modules are on their way out of core.

NoJavaScriptAnonymousTest refers to all modules in standard so that should be dealt with in #3243121: Remove RDF module from the Standard profile

EntityViewControllerTest has a small test method that probably needs porting to the RDF module.

UpdatePathTestBaseFilledTest tests the upgrade path from 9.3.0 so references to RDF will be removed there when we remove the module itself.

ConfirmClassyCopiesTest needs to stay while rdf-metadata.html.twig remains in the core themes.

To summarize I think only EntityViewControllerTest needs investigation here.

Add remaining task to IS.

I have looked at EntityViewControllerTest and I don't know how to modify it so test coverage is kept and RDF is removed.

Anyone? I'll have a go if someone points the way.\

The code in RDF that's being relied on is this (I think):

 * Implements hook_entity_prepare_view().
 */
function rdf_entity_prepare_view($entity_type, array $entities, array $displays) {
  // Iterate over the RDF mappings for each entity and prepare the RDFa
  // attributes to be added inside field formatters.
  foreach ($entities as $entity) {
    $mapping = rdf_get_mapping($entity_type, $entity->bundle());
    // Only prepare the RDFa attributes for the fields which are configured to
    // be displayed.
    foreach ($displays[$entity->bundle()]->getComponents() as $name => $options) {
      $field_mapping = $mapping->getPreparedFieldMapping($name);
      if ($field_mapping) {
        foreach ($entity->get($name) as $item) {
          $item->_attributes += rdf_rdfa_attributes($field_mapping, $item->toArray());
        }
      }
    }
  }
}

So what we'd need is a test module that sets $item->_attributes to something, and change the assertions to look for that instead.

@catch, thanks!

I made a new test module and used the same hook to add the same attribute.

Looking at EntityViewControllerTest again, I would argue that this piece of functionality is no longer worth testing.

EntityViewBuilder sets:

            $item->_attributes = [];

entity_test.module appends to this array:

          $item->_attributes += ['data-field-item-attr' => 'foobar'];

entity_view_controller_test also appends to this array:

        $item->_attributes += ['property' => 'schema:text'];

So really all we are doing is checking that PHP can correctly merge arrays. When RDF was involved I guess it was important to ensure that RDF didn't accidentally overwrite existing attributes, but there is nothing to stop a module overwriting $item->_attributes instead of merging, so the test proves nothing to me.

Otherwise the changes look fine to me. NW for #13 (or just to update the .info.yml if you disagree with #13).

Found via #3267703: Deprecate RDF module I think JsonApiRegressionTest::testLeakedCacheMetadataViaRdfFromIssue3053827() also needs moving to RDF module as an edge case in JSON API.

Sorry, I am blind, don't know how I didn't see that :)

Addressed #13 by removing the test.

In fact we can keep the spirit of the original tests by ensuring that the entity_test module adds two attributes, and then testing for both of them.

Unsure if we should decouple migrate_drupal_ui from RDF in here or in #3267703: Deprecate RDF module, the latter forces us because the tests fail with a deprecation error.

In general, I think it is best to have changes to migration tests in a separate issue so that only those changes are considered. Experience is showing that is difficult and we have made some mistakes. However, in this particular case lets update the migrate_drupal_ui tests here and not muddle up the deprecation issue. I have moved the changes to migrate_drupal_ui from #3267703: Deprecate RDF module to here.

Agreed with @quietone in #21 those migrate_drupal_ui changes look fine to include here since it's a pretty trivial change (unlike many others).

Looks like it's all there. Just a nitpick on a comment. Issue with EntityViewControllerTest has been resolved as far as I can see, removing from IS.

I don't feel too confident about knowing the ins and outs of the problem space but from what I can see patch does what the issue summary says it should do, so RTBC :)

Removed out of scope comment changes in the data provider, fixed two uses of ableist language in entity_test - while only one is technically in scope if we are going to fix one I think we should fix the other at the same time.

Went through the changes, searched for 'rdf' to see any missing places where the module is enabled. Ran RDF tests on the MR locally and they are green. I'd say, RTBC ^^

Committed to 10.1.x, 10.0.x, 9.5.x, and 9.4.x as a patch-eligible test cleanup. Thanks!

I think this may have introduced a fail on 9.4, so reverting there.

This issue seems to have removed a lot of important testing from Drupal Core: NodeDisplayConfigurableTest, node_display_configurable_test.info

This testing (that I spent quite a while writing) is/was an important part of the initiative #2353867: [META] Expose Title and other base fields in Manage Display. I have raised #3342700: Reinstate important testing NodeDisplayConfigurableTest. I hope that the authors of this issue might be willing to undo this accidental loss from their actions.