Problem/Motivation

Originally found in #3331424: Drop -moz- vendor prefixed properties and then discussed in Slack with @alexpott, @mherchel and @andy-blum.

In toolbar's CSS we have the following non-standard properties:

  -moz-tap-highlight-color: rgba(0, 0, 0, 0);
  -o-tap-highlight-color: rgba(0, 0, 0, 0);
  -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
  tap-highlight-color: rgba(0, 0, 0, 0);
  -moz-touch-callout: none;
  -o-touch-callout: none;
  -webkit-touch-callout: none;
  touch-callout: none;

These were originally introduced in an early prototype of the toolbar CSS in #1137920: Fix toolbar on small screen sizes and redesign toolbar for desktop

These properties are currently only supported by Safari on iOS, with the -webkit- vendor prefix, and even then we are not sure that they do anything useful.

https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout
https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-tap-highlight-c...

Steps to reproduce

Proposed resolution

Remove these properties.
Check for regressions on iOS.
If the properties are useful:

  • Keep only the -webkit- prefixed versions.
  • Add a comment explaining what the properties do.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

longwave created an issue. See original summary.

andy-blum’s picture

Note that these toolbar styles are also in Claro: https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/themes/clar...

longwave’s picture

Issue summary: View changes

longwave credited alexpott.

longwave credited mherchel.

longwave credited Spokje.

longwave’s picture

Adding issue credits for discussion and also @Spokje who created duplicates of this issue at the same time.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.