Problem/Motivation

@todo Refactor when https://www.drupal.org/node/3010558 is fixed.

core/themes/claro/templates/datetime-wrapper.html.twig
core/themes/claro/templates/form-element.html.twig

Refactor these two templates as https://www.drupal.org/node/3010558 is fixed.

As in the parent issue we have removed <strong> tag and added CSS font-weight: bold; on the form-item--error-message. We can bold the inline error messages here as well.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 3348130-9.patch948 bytesgauravvvv
#6 after-apply-patch.png137.72 KBguru2023
#2 3348130-2.patch1.9 KBgauravvvv

Comments

Gauravvvv created an issue. See original summary.

gauravvvv’s picture

gauravvvv CreditAttribution: gauravvvv at Axelerant for Drupal India Association commented
Status: Active » Needs review
StatusFileSize
new 3348130-2.patch1.9 KB
smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs issue summary update 
-  font-weight: normal;
+  font-weight: bold;

If this out of scope? Think this needs an issue summary update and title update to match what's going on. Description mentions updating templates (how). But there is CSS changes happening too.

So lets get a full issue summary for whats happening.

gauravvvv’s picture

gauravvvv CreditAttribution: gauravvvv at Axelerant for Drupal India Association commented
Issue summary: View changes
Status: Needs work » Needs review
guru2023’s picture

guru2023 CreditAttribution: guru2023 at Material commented
Assigned: Unassigned » guru2023
guru2023’s picture

guru2023 CreditAttribution: guru2023 at Material commented
StatusFileSize
new after-apply-patch.png137.72 KB

Verified the patch #2 and reviewed it on Drupal claro theme css. The patch is working fine and I have added the after patch screenshot for reference.

guru2023’s picture

guru2023 CreditAttribution: guru2023 at Material commented
Assigned: guru2023 » Unassigned
Status: Needs review » Reviewed & tested by the community
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Needs work

I think #3 is right that those changes are out of scope.

gauravvvv’s picture

gauravvvv CreditAttribution: gauravvvv at Axelerant for Drupal India Association commented
Status: Needs work » Needs review
StatusFileSize
new 3348130-9.patch948 bytes

Updated patch as per #8.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Reviewed & tested by the community

#9 seems correct. @laurii will leave to you if you want the issue summary update. Simple fix but know we try and fill those in when possible.

  • lauriii committed d746b86d on 10.1.x 
    Issue #3348130 by Gauravvvv, smustgrave: Claro: Remove outdated todo...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Title: Claro: Refactor template as #3010558 is fixed » Claro: Remove outdated todo comments
Status: Reviewed & tested by the community » Fixed

All is good – had to dig into the history of this already when I pushed back on #8. 😊

Committed d746b86 and pushed to 10.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.