Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.
This issue is to convert \Drupal\migrate\Annotation\MigrateDestinationplugins to use Attributes.
Proposed resolution
Convert remaining MigrateDestination plugins to attributes
Remaining tasks
#3424509: Update MigratePluginManager to include both attribute and annotation class
Review
Commit
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3421015-nr-bot.txt | 12.62 KB | needs-review-queue-bot |
Issue fork drupal-3421015
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3421015-convert-migratedestination-plugin
changes, plain diff MR !6798
1 hidden branch
Comments
Comment #4
godotislate CreditAttribution: godotislate at Digital Polygon commentedNote that change to `core/modules/migrate/src/Plugin/MigratePluginManager.php` is also needed by other migrate plugins.
Comment #5
needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #6
godotislate CreditAttribution: godotislate at Digital Polygon commentedRebased.
Comment #7
mohit_aghera CreditAttribution: mohit_aghera at PreviousNext commentedNote: BC approach to handle annotations and attributes in
MigratePluginManagerclass is being evaluated in https://www.drupal.org/project/drupal/issues/3424509We should revisit and rebase this PR after this is resolved.
Comment #8
smustgrave CreditAttribution: smustgrave at Mobomo commentedSearched for @MigrateDestination and all 31 instances in core have been replaced.
Checked the attribute for the deriver class and no @Annotation.
Believe this one is good.
Comment #9
godotislate CreditAttribution: godotislate at Digital Polygon commentedBlocked on #3424509: Update MigratePluginManager to include both attribute and annotation class.
Comment #10
catchComment #11
quietone CreditAttribution: quietone at PreviousNext commentedComment #12
quietone CreditAttribution: quietone at PreviousNext commentedComment #13
alexpottComment #14
godotislate CreditAttribution: godotislate at Digital Polygon commentedRe-opening because the balance of destination plugins outside a couple done in #3424509: Update MigratePluginManager to include both attribute and annotation class still need to be converted. MR here has been rebased and is ready for review.
Comment #15
smustgrave CreditAttribution: smustgrave at Mobomo commentedBelieve 2 were missed EntityFile and Book.php
Comment #16
godotislate CreditAttribution: godotislate at Digital Polygon commentedThose two were already done in #3424509: Update MigratePluginManager to include both attribute and annotation class
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/book/...
Comment #17
smustgrave CreditAttribution: smustgrave at Mobomo commentedYou are correct, that's my mistake
Rebase my local and applying MR all instances of @MigrateDestination have been replaced.
Comment #18
alexpottCommitted and pushed 38e722aa6f to 11.x and 3f64e2bf2c to 10.3.x. Thanks!