Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
To run an upgrade the role_permission table needs to exist or an error is caused which stops the upgrade pages from getting to the next selection page.
I have added to the update_fix_d7_requirements() to create the role_permission table so that it can get past the check.
This still gets updated during the upgrade, but the table exists.
Comment | File | Size | Author |
---|---|---|---|
#16 | role_permission.patch | 2.91 KB | catch |
#14 | role_permission.patch | 2.53 KB | catch |
#12 | role_permission.patch | 2.07 KB | catch |
#8 | 0001-role_permission-required-to-upgrade.patch | 2.73 KB | gordon |
#3 | 0001-role_permission-required-to-upgrade.patch | 2.78 KB | gordon |
Comments
Comment #1
David_Rothstein CreditAttribution: David_Rothstein commentedStrangely, I am able to reproduce this issue, but only occasionally. Most of the time I've tried upgrading, it works fine. But on a few occasions (with no discernible pattern whatsoever), I have seen this error.
In particular, the error message occurs during system_update_7007() and consists of:
It would be ideal if we could figure out what's causing this issue, before trying to work around it - but I have no ideas at the moment, and the fact that it's only an intermittent problem is troubling :)
Comment #3
gordon CreditAttribution: gordon commentedUpdated version of the patch
Comment #4
catchI've had this when a contrib (7) module has been installed, which calls user_access(), such as devel does in hook_boot().
Comment #5
gordon CreditAttribution: gordon commentedOpps forgot to change the status
Comment #6
gordon CreditAttribution: gordon commentedYes this explains it, and why it is going to be a problem in a future.
Comment #8
gordon CreditAttribution: gordon commentedFix up the conflicts in the patch
Comment #10
lilou CreditAttribution: lilou commentedHEAD is broken.
Comment #12
catchRe-rolled.
Comment #13
webchickAhaha. I am a slacker for not catching that in the last patch. :)
Why are you setting this here when it's already being set further down?
Why do we need this hunk anymore if we're taking care of this in update_fix_d7_requirements() now?
This review is powered by Dreditor.
Comment #14
catchRemoved bogus variable_set(), removed table creation from 7007()
Comment #15
webchickOops. It just occurred to me from reading this hunk that we need to add that table definition to update_fix_d7_requirements(). drupal_get_schema_unprocessed() is going to get the /current/ schema of the table, which may or may not be the same in 7.0 as it is in 7.24.
See also http://drupal.org/node/150220
I'm on crack. Are you, too?
Comment #16
catchInclude full schema definition in update_fix_d7_requirements().
Comment #17
webchickAwesome, think we got it now. :)
Committed to HEAD!