Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.With the use of array arguments, db_query() now requires the second argument to be an array, and there was still one query used by search (in node.module) that was wrong.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 581594.patch | 2.5 KB | douggreen |
| #2 | 581594.patch | 1.5 KB | douggreen |
| search-dbtng.patch | 1.18 KB | douggreen | |
Comments
Comment #1
Dries CreditAttribution: Dries commentedI committed this to CVS HEAD. Thanks Doug.
However, it illustrated that we don't have good enough test coverage yet for search module. So I'm marking this 'code needs works', and I've added a tag.
Comment #2
douggreen CreditAttribution: douggreen commentedHere's a simple first cut at a test. This test would of caught this problem, ... but not too much more. It makes sure that the config settings for renders, and that the re-index button works.
Comment #3
douggreen CreditAttribution: douggreen commentedNeeds additional work to test for #569084: Search reset module_invoke_all() issue... I'm working on it.
Comment #4
douggreen CreditAttribution: douggreen commentedNote, that this also tests for #569536: Search links cause many nodes to be indexed twice and #569084: Search reset module_invoke_all(). Since the first patch isn't committed yet, I've included it here, otherwise, the automated testing system would reject this patch.
Comment #6
sun.core CreditAttribution: sun.core commentedWhat's left here?
Comment #7
BerdirI've incorporated the tests into #569536: Search links cause many nodes to be indexed twice so I think this can be set to fixed.