Because the original issue has way too many replies (two pages already) and floods the testbot with re-test requests with all of it's patches, I wanted to get a clean issue for #58224: Allow anonymous users access to a members personal contact form. Latest patch attached for review.

Executive summary:
1. Adds a new permission 'access personal contact forms'
2. Makes personal contact forms act like the site-wide contact forms where you can enter your name and e-mail. This was necessary to open this up to anonymous users.
3. Brings some cleanups from the personal contact form submit handler back to the site-wide contact form as well.
4. Fixes some placeholders that were not properly replaced in e-mail messages
5. Adds tests for anonymous personal contact form access.
6. Saves name and e-mail fields to the visitor cookie if entered by anonymous users on the personal contact forms, just like the site-wide contact form and comment forms. Yay for re-use and making it easier for anonymous users!

CommentFileSizeAuthor
#24 601250-followup-D7.patch744 bytesDave Reid
#22 601250-followup-D7.patch818 bytesDave Reid
#21 601250-followup-D7.patch819 bytesDave Reid
#10 601250-user-contact-anonymous-D7.patch14.85 KBDave Reid
#7 58224-user-contact-anonymous-D7_2.patch14.76 KBVM
#4 58224-user-contact-anonymous-D7.patch14.76 KBDave Reid
58224-user-contact-anonymous-D7.patch14.75 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Issue tags: +D7 API clean-up

Adding tag. This is an incomplete feature, and one of the major things holding back contact.module. And it was easy.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Issue tags: -D7 API clean-up

webchick and I agreed that this was not an API change even with a new permission and validation function, so it could wait until post-slush freeze. But I wouldn't mind if it were committed sooner.

Status: Needs review » Needs work

The last submitted patch failed testing.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Needs review
FileSize
58224-user-contact-anonymous-D7.patch14.76 KB

Helps to use the correct permission name everywhere...

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Category: feature » task

Since the feature for contact forms already exists and this this correcting an implementation bug, I am marking this as a task.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Category: task » feature
Status: Needs review » Needs work

Great patch! And very useful feature!

+++ modules/contact/contact.module	11 Oct 2009 03:50:41 -0000
@@ -45,6 +45,10 @@ function contact_permission() {
+      'title' => t("Access users' personal contact forms"),

user's not users'

VM’s picture

VM CreditAttribution: VM commented
Category: feature » task
Status: Needs work » Needs review
FileSize
58224-user-contact-anonymous-D7_2.patch14.76 KB

corrected typo and reuploaded.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Needs work

name and e-mail fields to the visitor cookie if entered by anonymous users on the personal contact forms, just like the site-wide contact form and comment forms. Yay for re-use and making it easier for anonymous users!

This does not work for we (WinXP ff35 , google chrome, safari 4)

greg.harvey’s picture

greg.harvey
Primary language English
CreditAttribution: greg.harvey commented

@andypost, trivial point really, but I'm not sure that was a typo - if it's referring to users in the plural, i.e. all users, then Access users' personal contact forms would be correct. user's is correct if referring to a single user's contact form.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Needs review
FileSize
601250-user-contact-anonymous-D7.patch14.85 KB

Yeah technically it was correct, but this permission should be standardized with other permissions like 'access user profiles'. Ergo, revised patch with a 'access user contact forms' permission.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Anonymous users now send messages!

Yay for re-use! tested (WinXP ff35 , google chrome, safari 4, opera 10 and IE6) - all of them works

tested flood! - blocks if browsers from 1 ip

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

This looks good to me. Committed to CVS HEAD. Thanks.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Thanks Dries! Seems fitting that this issue was fixed on the *exact* 3.5 year anniversary of when this issue first started in #58224: Allow anonymous users access to a members personal contact form - April 11, 2006!

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

People from #58224: Allow anonymous users access to a members personal contact form that also deserve credit for this:

Patchers: karschsp, matt@antinomia, David Lesieur, Owen Barton, pwolanin, TBarregren, coltrane, mrtoner, deviantintegral, rleigh, swaroopch, jonhinkle

Reviewers: mfer, scottrigby, greg.harvey, Michelle, binford2k, andrewfn, dalin, Rosamunda, chx, lreid, ggamba, tizzo, wanabeanon, rhimes, Chad_Dupuis, Dries, pp, drewish, killes@www.drop.org, bradlis7, agentrickard, bflora, christefano, naquah, davbusu, j0rd, renee, keith.smith, tstoeckler, borfast

gpk’s picture

gpk CreditAttribution: gpk commented
Status: Fixed » Needs work

Great stuff :)

I notice that this has caused a partial rollback of #229660: Use theme_username() in the personal contact form, specifically the sender's default name has reverted to being just their account username i.e. $user->name, whereas the recipient still gets shown according to the change in that issue, i.e. their themed username is shown. As well as potentially creating a link to the recipient's profile page this also allows the recipient's real name to be shown on their contact page, e.g. if profile fields are used to store the real name and if a theme override is used).

This is pretty minor though, #10 is still a really useful improvement.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Fixed

@gpk: Yes, this basically works exactly like the site-wide contact form now. I was thinking about creating a follow-up issue to tighten both site-wide and personal contact forms to not allow logged-in users to enter their name or e-mail, much like comment forms change between anonymous and regular users. Let's fix this in a follow-up.

We didn't change anything about showing the recipients name so I'm not sure what you are talking about.

gpk’s picture

gpk CreditAttribution: gpk commented

Yes, what I'm saying is that we've lost the theme_username() aspect for just the sender, not for the recipient, so this is potentially a bit confusing now.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Suppose this task should go to #192056: User's raw login name should not be output directly

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

No this is a specific problem for contact.module. That issue is not related to putting the user name in input fields, just displaying it. Follow-up in #601776: Remove the ability of registered users to change the sender name or email address in contact forms..

The only true followup concern I have is that by default any registered user could access personal contact forms in D6. Now that we have a permission for this, when sites upgrade to D6 from D7, should we add the permission for authenticated users in an update function so sites don't 'lose' functionality?

gpk’s picture

gpk CreditAttribution: gpk commented

> should we add the permission for authenticated users in an update function so sites don't 'lose' functionality?
Yes, but perhaps only if contact.module is enabled.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Fixed » Needs review
FileSize
601250-followup-D7.patch819 bytes

Follow-up to add the 'access user contact forms' for registered users on update. Will not affect new installs of contact.module in D7.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
601250-followup-D7.patch818 bytes

Last patch was invalid.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Needs work

Try using RoleAPI http://api.drupal.org/api/function/user_role_grant_permissions/7

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Needs review
FileSize
601250-followup-D7.patch744 bytes

The fact that I forget about issues that I had a hand it is funny or sad. Thanks andypost for reminding me. :)

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Much better

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Sivaji_Ganesh_Jojodae’s picture

Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented

Is there any chances of backporting this features to drupal 6.x ?

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

@sivaji http://drupal.org/node/58224#comment-2138596

Sivaji_Ganesh_Jojodae’s picture

Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented

@andypost thanks for the link but contact_anon [1] has no d6 port.

[1] http://drupal.org/project/contact_anon