Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There is a simple bug in menu_tree_output() that accidentally resets the 'localized_options' array before it gets to the l() function. This currently prevents all title attributes, query arrays, etc from rendering in the resulting menu links.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | menu-link-options3.patch | 2.13 KB | carlos8f |
| #5 | menu-link-options2.patch | 2.13 KB | carlos8f |
| #3 | menu-link-options.patch | 2.13 KB | carlos8f |
| localized-options-fix.patch | 925 bytes | carlos8f | |
Comments
Comment #1
moshe weitzman CreditAttribution: moshe weitzman commentedgood catch.
Comment #2
webchickCan we get a test for this?
Comment #3
carlos8f CreditAttribution: carlos8f commentedAdded a test, which tests for the title attribute and query string on a rendered menu link. Verified that the test fails on HEAD, but passes with the fix.
Comment #5
carlos8f CreditAttribution: carlos8f commented#3 passed in my environment. Tweaking to see if this passes the testbot.
Comment #7
carlos8f CreditAttribution: carlos8f commentedI think the fail happened because testbot's simpletest must have clean URL's off, whereas my simpletest has them on.
Comment #8
grndlvl CreditAttribution: grndlvl commentedLooks good.
Comment #9
webchickExcellent. Thanks much, carlos!
Committed to HEAD.