See the attached screenshot - on the top right corner of the front page, anonymous users now have a link that says "User account" that was never there before, and is pretty confusing (because if you aren't logged in you don't have a user account yet...)

This appears to be a side effect of #925778: User edit title is broken (so is beta1-beta2 upgrade path).

CommentFileSizeAuthor
#2 anon_user_account_link.patch695 bytesrjgoldsborough
#2 anon_user_login_register_link.png39.08 KBrjgoldsborough
user_account_link.png37.41 KBDavid_Rothstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Haza’s picture

Haza
Primary language French
CreditAttribution: Haza commented

According to the code/comment we have in user.module, this is what we expected, but I agree that this is confusing

/**
 * Menu item title callback for the 'user' path.
 *
 * Anonymous users should see "User account", but authenticated users are
 * expected to see "My account".
 */
function user_menu_title() {
  return user_is_logged_in() ? t('My account') : t('User account');
}
rjgoldsborough’s picture

rjgoldsborough CreditAttribution: rjgoldsborough commented
Status: Active » Needs review
FileSize
anon_user_login_register_link.png39.08 KB
anon_user_account_link.patch695 bytes

I also agree this is confusing. This patch simply changes that link from "User Account" to "Login/Register" which I think makes much more sense.

Status: Needs review » Needs work

The last submitted patch, anon_user_account_link.patch, failed testing.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented

Although I tried to start a new issue instead, it looks like #925778: User edit title is broken (so is beta1-beta2 upgrade path) was reopened and the latest patch there addresses this too :( Maybe we should close this as a duplicate at this point?

The approach in the patch here is interesting, but we wouldn't want to say "register" always because some sites don't allow user registration. Also, as described at http://drupal.org/node/925778#comment-3558074, this title is also used as the title of the user login page itself, so changing it affects more than just the link title.

I'm guessing we do just want to remove the link completely (i.e. go back to the way it was before), which I think the patch on the other issue does.

rjgoldsborough’s picture

rjgoldsborough CreditAttribution: rjgoldsborough commented
Status: Needs work » Closed (duplicate)

Sounds good to me. They seem to have a much more solid patch over there anyway. Good point about using "register", I didn't really think about that. I also noticed the second error you mentioned after the failed test. But all in all, I agree we can close this as a duplicate as this issue seems to be fully addressed elsewhere.