Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
I don't think I've ever viewed the issue credit UI as a non-maintainer prior to working on #2810485: Allow more maintainers to grant credit but I was hugely confused when I did.
Here's what a maintainer sees:
Here's what a non-maintainer sees:
Do you, like me, see absolutely no difference? There's one tiny (and I do mean tiny :)) one:
And... that's it. Otherwise, this field appears to work just fine, right up into telling you the issue updated successfully. It's just that your data changes aren't actually saved:
Proposed resolution
Something a lot more explicit. I'm guessing the entire form is visible right now because there's value in non-maintainers seeing the list and how it's checked so they can point out errors/omissions in crediting. Which makes sense, especially until #2810485: Allow more maintainers to grant credit is fixed.
As a VERY MVP, we could just prepend different text like "Only project maintainers are allow to modify this field." But we could likely do a lot better than that, too.
User interface changes
Yes. Let's discuss.
Remaining tasks
TBD.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | Screen Shot 2019-02-11 at 11.03.25 AM.png | 27.63 KB | drumm |
| #4 | Screen Shot 2019-02-11 at 11.02.38 AM.png | 40.65 KB | drumm |
| #4 | Screen Shot 2019-02-11 at 11.06.29 AM.png | 21.15 KB | drumm |
| tiny.png | 25.25 KB | webchick | |
| Screen Shot 2018-06-07 at 4.46.01 PM.png | 217.11 KB | webchick |
Comments
Comment #2
webchickComment #3
drummYes, and for commit messages when pushing to branches.
Comment #4
drumm#2972225: Move from opt in to opt out for contribution attribution has some related discussion.
As an initial change, I’m adding a credit summary for non-maintainers. This behaves somewhat like the existing summary for maintainers, but only shows the awarded credit instead of updating as a maintainer updates credit. Both show when the fieldset is collapsed, too.
Before a maintainer has commented, or if they have commented and no one has credit:
Once a maintainer has commented, when the issue is still open:
When the issue is fixed:
Leaving this issue open for now, since I don’t know if I’ve fully resolved this. Let me know if the copyediting needs work, or if you have more ideas. I plan to deploy this set of changes today.
Comment #6
tim.plunkettI think the key part missing is seeing who has credit already and who is about to get credit, if I am returning to an issue that a maintainer has already commented on.
Comment #7
drummI split that out to #3032181: Add “credit given by maintainer” indication to Credit & committing fieldset, since it is good for both maintainers & non-maintainers.