Getting following error/warnings
FILE: /app/modules/contrib/easy_breadcrumb/easy_breadcrumb.module
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
48 | ERROR | [x] Expected 1 space after IF keyword; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: /app/modules/contrib/easy_breadcrumb/src/EasyBreadcrumbBuilder.php
--------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------
274 | ERROR | [x] Whitespace found at end of line
294 | ERROR | [x] Expected 1 space after IF keyword; 0 found
360 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
887 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
899 | WARNING | [x] There must be no blank line following an inline comment
899 | WARNING | [ ] There must be no blank line following an inline comment
900 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------
FILE: /app/modules/contrib/easy_breadcrumb/src/EasyBreadcrumbConstants.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
145 | WARNING | Line exceeds 80 characters; contains 96 characters
--------------------------------------------------------------------------
FILE: /app/modules/contrib/easy_breadcrumb/src/EasyBreadcrumbStructuredDataJsonLd.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
14 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------
FILE: /app/modules/contrib/easy_breadcrumb/src/Form/EasyBreadcrumbGeneralSettingsForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
128 | ERROR | [x] Opening brace must be the last content on the line
128 | ERROR | [x] There should be no white space after an opening "{"
128 | ERROR | [x] There should be no white space before a closing "}"
128 | ERROR | [x] Closing brace must be on a line by itself
128 | WARNING | [ ] Menu::loadMultiple calls should be avoided in classes, use dependency injection instead
128 | ERROR | [x] Each PHP statement must be on a line by itself
134 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
377 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /app/modules/contrib/easy_breadcrumb/src/TitleResolver.php
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------
11 | WARNING | [x] Unused use statement
20 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------
FILE: /app/modules/contrib/easy_breadcrumb/tests/src/Kernel/EasyBreadcrumbBuilderTest.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
23 | ERROR | The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------
Time: 922ms; Memory: 18MB
| Comment | File | Size | Author |
|---|
Issue fork easy_breadcrumb-3323769
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 2.x
compare
- 3323769-drupal-coding-standards
changes, plain diff MR !72
Comments
Comment #2
samitk commentedError/Warnings Fixed.
Comment #3
kunal_sahu commentedI am reviewing this patch.
Comment #4
gaurav-mathur commentedComment #5
gaurav-mathur commentedVerified and tested patch #2 on Drupal 10.1.x-dev and do not see any error or warnings.
Patch applied successfully.
Thank You.
Comment #6
greg boggsHi folks, thanks for working on this issue. If someone can open a merge request, I can get this added.
Comment #9
Sonal Gyanani commentedThanks, patch #2 works fine all errors & warnings are fixed.
Created merge request for the same.
Comment #10
greg boggsneeds a reroll.
Comment #11
samitk commentedHi @Greg Boggs,
Reroll with #2.
Comment #13
samitk commentedFixed #11
Reroll with #2.
Comment #14
greg boggsCan we get this as a merge request?
Comment #15
kunal_sahu commentedHey Greg , So i tried to apply the patch resulted into some errors and then i thought to fix them and create an MR but unfortunately I pushed my changes to 2.x branch. I can assure you that the Coding standards issue are solved.
Please consider my MR.
https://git.drupalcode.org/issue/easy_breadcrumb-3323769/-/commit/c23485...
Thanks.
Comment #16
diego_mow commentedMerge request from #15 worked fine for me!
https://git.drupalcode.org/issue/easy_breadcrumb-3323769/-/commit/c23485...
Comment #17
greg boggsMR needs a rebase from the current code.
Comment #18
spuky commentedshould get closed by 3454226 which fixes all outstanding pcs and phpstan issues
Comment #19
spuky commentedAll Coding standard Issues are fixed in our Test suite