Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The module has issues with coding standards.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | interdiff_2-4.txt | 4.43 KB | tmaiochi |
| #5 | 3259815-4.patch | 7.83 KB | tmaiochi |
| #2 | editablefields-fix_codding_standards-3259815-2.patch | 3.82 KB | Yurii O. |
Issue fork editablefields-3259815
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #2
Yurii O. CreditAttribution: Yurii O. at DevBranch commentedpls check it
Comment #3
tmaiochi CreditAttribution: tmaiochi at CI&T commentedI'll review this.
Comment #4
gilmord@Yurii O. patches is the old way to resolve the issues
please follow a new forks & MRs guide and create a merge request
thanks!
Comment #5
tmaiochi CreditAttribution: tmaiochi at CI&T commentedThe patch had some phpcs problems. I fixed some of them, but it has a warning about unused variable, however the variable is in using. So I left it at that and didn't change anything about this warning. I also sending the interdiff.
Comment #6
gilmord@tmaiochi please use the forks & MRs flow mentioned a few comments above, so I can merge it.
Comment #7
victoria-marina CreditAttribution: victoria-marina at CI&T commentedI'll review it.
Comment #8
victoria-marina CreditAttribution: victoria-marina at CI&T commentedThe #5 worked for me! RTBC