Problem/Motivation

In our usecase it was necessary to extend the SearchAction, SearchActionFactory and SearchController classes.
Some improvements are required for the following problems:

  • SearchActionFactory class variables have private visibility
  • SearchActionFactory does not have an interface
  • The $searchAction variable would be useful as a class property in the SearchController, this way we can use data from it in extended methods that don't have it as an argument (getSearchHeader() for example)

Proposed resolution

  • Within SearchActionFactory, change the visibility of $size, $termStorage and getHierarchicalValues() to protected instead of private
  • Implement a SearchActionFactoryInterface and replace type hints
  • Add a $searchAction class property to the SearchController
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Joris Handstanger created an issue. See original summary.

joris handstanger’s picture

Issue summary: View changes

joris handstanger’s picture

Status: Active » Needs review