Early Bird Registration for DrupalCon Atlanta is now open! By registering during our Early Bird Registration window, you’ll save $100. This window ends on 19 January 2025 and will go by quickly, so don’t wait!
Problem/Motivation
In our usecase it was necessary to extend the SearchAction, SearchActionFactory and SearchController classes.
Some improvements are required for the following problems:
- SearchActionFactory class variables have private visibility
- SearchActionFactory does not have an interface
- The $searchAction variable would be useful as a class property in the SearchController, this way we can use data from it in extended methods that don't have it as an argument (getSearchHeader() for example)
Proposed resolution
- Within SearchActionFactory, change the visibility of $size, $termStorage and getHierarchicalValues() to protected instead of private
- Implement a SearchActionFactoryInterface and replace type hints
- Add a $searchAction class property to the SearchController
Issue fork elasticsearch_search_api-3467587
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
joris handstanger CreditAttribution: joris handstanger at Anvil for VDAB commentedComment #4
joris handstanger CreditAttribution: joris handstanger at Anvil for VDAB commented