Problem/Motivation

In case patch in EntityReferenceFieldItemList::referencedEntities should return the translated entity is used, then it leads to an error when using err as follows,
Fatal error: Declaration of Drupal\entity_reference_revisions\EntityReferenceRevisionsFieldItemList::referencedEntities() must be compatible with Drupal\Core\Field\EntityReferenceFieldItemList::referencedEntities(?string $langcode = NULL) in /var/www/html/web/modules/contrib/entity_reference_revisions/src/EntityReferenceRevisionsFieldItemList.php on line 21

Steps to reproduce

Apply patch in - https://www.drupal.org/node/2915972
Try to visit a form where ERR fields is used.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 3320825-11_supporting_patch_EntityReferenceFieldItemList.patch585 bytesandreadruiz
#5 support-for-core-patch-3320825-5.patch585 bytesmkrizaj
#4 support-for-core-patch-3320825-3.patch4.74 KBmkrizaj
#3 support-for-core-patch-3320825-2.patch1.56 KBmkrizaj
#2 Issue-3320825-supporting-patch-for-core-patch-EntityReferenceFieldItemList-referencedEntities-should-return-translated-entity-01.patch542 bytesd34dman

Issue fork entity_reference_revisions-3320825

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

D34dMan created an issue. See original summary.

d34dman’s picture

d34dman commented
StatusFileSize
new Issue-3320825-supporting-patch-for-core-patch-EntityReferenceFieldItemList-referencedEntities-should-return-translated-entity-01.patch542 bytes

I have trouble pushing the commit via git... so here is the patch

mkrizaj’s picture

mkrizaj commented
StatusFileSize
new support-for-core-patch-3320825-2.patch1.56 KB

Hey,

You've missed adding logic to load a translatable entity, so I am adding a new patch.

Thanks,
Matic

mkrizaj’s picture

mkrizaj commented
StatusFileSize
new support-for-core-patch-3320825-3.patch4.74 KB

Adding fixes for drupal coding standards.

mkrizaj’s picture

mkrizaj commented
StatusFileSize
new support-for-core-patch-3320825-5.patch585 bytes

Attaching new patch for latest version.

chetan 11 made their first commit to this issue’s fork.

chetan 11 opened merge request !40

chetan 11’s picture

chetan 11 commented
Status: Active » Needs review

please check the above MR.

d34dman’s picture

d34dman commented

@mkrizaj,

The patch in #5 is same as the one posted in #1, could you explain why?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Postponed
andreadruiz’s picture

andreadruiz commented
StatusFileSize
new 3320825-11_supporting_patch_EntityReferenceFieldItemList.patch585 bytes

Hi all, I am adding the same patch but compatible with 8.x.1.x version. Thanks!