Problem/Motivation

ECK entities in particular, and maybe other entities extend from ContentEntityBase, and therefore implement RevisionableInterface, but do not actually support or have revisions. Nevertheless, these entities get labelled "Translations or previous revisions" in the usage view. Instead, if there are no revisions, they should be labelled "default"

Proposed resolution

Adjust ListUsageController.php to not just check if $record['source_vid'] == $default_revision_id to determine whether the label for a source entity should be "default" or "Translations or previous revisions," but also set it to "default" when $default_revision_id ($source_entity->getRevisionId() ) is null.

CommentFileSizeAuthor
#2 entity_usage-usages_that_have_no_revisions_mislabled-3408306-2.patch768 bytesdgroene

Issue fork entity_usage-3408306

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dgroene created an issue. See original summary.

dgroene’s picture

dgroene CreditAttribution: dgroene at The College Board commented
StatusFileSize
new entity_usage-usages_that_have_no_revisions_mislabled-3408306-2.patch768 bytes
dgroene’s picture

dgroene CreditAttribution: dgroene at The College Board commented
Status: Active » Needs review

silvi.addweb made their first commit to this issue’s fork.

silvi.addweb opened merge request !77

silvi.addweb’s picture

silvi.addweb CreditAttribution: silvi.addweb at AddWeb Solution Pvt. Ltd. for AddWeb Solution Pvt. Ltd. commented
Status: Needs review » Reviewed & tested by the community

It's working fine and also raised MR for the same.

marcoscano made their first commit to this issue’s fork.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano as a volunteer and at Lullabot commented
Assigned: dgroene » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks for opening and working on a fix.
I would have preferred that we add test coverage for the new scenario we are supporting, but it's fine as-is, I'm getting the fix in in the meantime.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.