Entity selection target bundle settings are not enforced [#2516716]

Scenario:
- Create a ER field "field_foo", target type node, bundle type "foo"
- Create a new node
- Type in a value "bar (123)" where 123 is nid for node with type "bar" into "field_foo"

Expected behavior:
- ER should validate against target bundle settings, and throw an error

Observed behavior:
- ER allows value to be saved without any validation against bundle

Comment	File	Size	Author
#3	entityreference-bundle_settings_validation-2516716-2.patch	6.39 KB	aaronbauman
#1	entityreference-bundle_settings_validation-2516716-1.patch	5.65 KB	aaronbauman

Comments

Comment #1

aaronbauman

he/him

commented 1 July 2015 at 16:55

Status:

Active

» Needs review

Status	File	Size
new	entityreference-bundle_settings_validation-2516716-1.patch	5.65 KB

OK, this ended up touching a bunch of different pieces, including a related bug in entityreference_field_validate().
Fortunately the patch is relatively straightforward, and includes tests.

In this patch:

Update entityreference_field_validate() to actually perform validation when no valid references are given. (Previously validation was ignored if there was only one invalid reference).
Update EntityReference_SelectionHandler_Generic::validateReferencableEntities() to filter by target bundle settings if applicable.
Add a test for target bundle settings.
Update EntityReferenceHandlersTestCase::assertReferencable() to properly count multi-bundle arguments / target bundle settings.