Needs review
Project:
Entity reference
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
22 Mar 2016 at 05:16 UTC
Updated:
3 Jul 2020 at 13:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
brucelee1985 commentedComment #3
nwom commentedSetting to needs review and removed the tags (See Issue Guidelines). Thanks for the patch. I hope this gets added to the module.
Comment #5
nwom commentedHere is an updated patch that fixes a few white space and consistency issues. Please review.
Comment #6
badjava commentedThere are still some spacing issues near the bottom of #5.
should be
Comment #7
caminadaf commentedI've reviewed the diff using phpcs with Drupal and DrupalPractice standards, not it should be OK.
Comment #8
chinmay_p commentedTested the patch against version 7.x-1.1.Upon selecting entity reference,It gives option to add target. When "_blank" is added in target field,it gets open in new tab.
This patch works as expected.
Comment #10
hexblot commentedStarted using the patch in #7 on two sites, and it works wonderfully. A small change made by me in order to help novice site builders is to abstract the textfield in favor of a simple select control (New Window vs Same Window instead of a blank text field), it should help with usability.
It is heavily based on the patch in #7 (just FAPI changes, and display).
Comment #11
spotzero commentedActually, patch #7 has the valid behaviour. See: http://www.w3schools.com/TAGS/att_a_target.asp
Link targets can be any string when you're working with named frames.
What patch #7 needs is help text. ;)
Comment #13
oleh chemerys commentedThe issue still exists in 1.4 version, so I've updated the patch #7.
Comment #14
arlina commentedUpdated the patch for version 7.x-1.5.
Comment #15
chris matthews commentedUnassigned @brucelee1985
Comment #16
markusd1984 commentedthanks @ Arlina, I used the code and made something similar for the entity registration module, and also just now changed it to use a checkbox instead of a text field since usually only the "_blank" target type is of real practical use and thus no need for custom entry i supposes.
https://www.drupal.org/project/registration/issues/3156687#comment-13732212
Code below, may need to be adjusted for ER.
The below needs more review to probably make checkbox work with ER.