Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Sub-issue for meta issue #1880976: [meta] Port examples (including submodules) to D9.4+
Problem/Motivation
D8 all the things!
Proposed resolution
Start with D7 version and figure out how to port ;)
Comment | File | Size | Author |
---|---|---|---|
#7 | 2102665_7.patch | 13.56 KB | Mile23 |
#7 | interdiff.txt | 6.6 KB | Mile23 |
#3 | 2102665-diff-1-3.txt | 1.73 KB | vijaycs85 |
#3 | 2102665-js_example-convert-d8-3.patch | 10.43 KB | vijaycs85 |
#1 | Screen Shot 2013-11-30 at 21.38.20.png | 77.99 KB | vijaycs85 |
Comments
Comment #1
vijaycs85Initial patch...
Tested locally and working like D7.
Comment #2
Mile23Thanks, vijaycs85. Looks like a great start.
Lets rename this thing to be 'JavaScript Example.'
A few references to Drupal 7.
Let's follow the other examples and use a path of /examples/js_example/whatever.
Also, we need a route and controller for /examples/js_example, with a little bit of explanation of what's going on.
Overall it would be good to have more inline comments and docblocks explaining the code.
Thanks.
Comment #3
vijaycs85Thanks for the review @Mile23. Here is the updates.
#2.1 - FIXED
#2.2 - FIXED
#2.3 - FIXED
#2.3.1 - NOT-FIXED: "Also, we need a route and controller for /examples/js_example, with a little bit of explanation of what's going on." - Not sure what really we need to have on that page.
#2.3.2 - NOT-FIXED: "inline comments and docblocks explaining the code" - Again not sure what needs to be covered.
Comment #4
Mile233: 2102665-js_example-convert-d8-3.patch queued for re-testing.
Comment #6
Mile233: 2102665-js_example-convert-d8-3.patch queued for re-testing.
Comment #7
Mile23Added info page, fixed some routing stuff, added menu items, expanded some inline comments, added a few @ingroups, now tests for the existence of paths for some regression value.
Comment #8
Mile23And... committed. http://drupalcode.org/project/examples.git/commitdiff/87b72912d34bca5dd5...
Thanks, vijaycs85!
Comment #9
vijaycs85yay!!! thank you too @Mile23