Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We're adding the External Links module to Drupal Gardens at Acquia. This patch includes some touch-ups to language and the configuration form based on feedback from our UX folks. We could implement this all with form_alters, but it seems like other people might like this fine-tuning too.
- Add more detail to .info file for module description.
- Tighten up language on config page.
- Get rid of icons on config page (this will be confusing for people who change the icon).
- Make pop-up warning text area conditional, based on the checkbox that enables pop-ups.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | extlink-d6-1247644-1.patch | 3.93 KB | elachlan |
| #5 | extlink-1247644-5.patch | 3.89 KB | elachlan |
| #4 | 1247644-language-and-ui-edits-4.patch | 3.95 KB | mstef |
| #1 | 1247644-language-and-ui-edits.patch | 3.94 KB | bryanhirsch |
Comments
Comment #1
bryanhirsch CreditAttribution: bryanhirsch commentedComment #2
quicksketchThese look pretty good but I'd prefer to keep the icons in the description text, but that's actually been a problem in #963374: Use sprite for icons, so removing them would unblock that issue... I'll have to weigh them together.
Comment #3
bryanhirsch CreditAttribution: bryanhirsch commentedOk. Thanks for considering it.
Comment #4
mstef CreditAttribution: mstef commentedRerolled to apply to 7.x-1.12.
Comment #5
elachlan CreditAttribution: elachlan commentedRe-rolled the patch. Did not remove the images as per #2.
Comment #6
elachlan CreditAttribution: elachlan commentedCommitted to git. It will need to be ported to 6.x and 8.x.
Comment #7
elachlan CreditAttribution: elachlan commentedJust changing it to be 6.x port only. I have changed 8.x.
Comment #8
elachlan CreditAttribution: elachlan commentedCommitted to Git.