Needs review
Project:
Facet API Bonus
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Jul 2013 at 11:23 UTC
Updated:
28 Jan 2016 at 14:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
fagoLooks like the patch contains shell control characters?
Re-rolled patch. It probably makes sense to commit this one once #1393928: Add a per-facet setting that allows only one item to be active at a time landed.
Comment #2
maximilianmikus commentedok fixed the patch, the patch from fago was missing changes in the .info file.
Comment #3
vintorg commentedI just rolled patch #2. Are there supposed to be 2
facetapi_bonus_facetapi_widgets()functions? I assume not.Comment #4
vintorg commentedAlso, issue with the .info file. I had to add the line by hand.
reject file:
Comment #5
vintorg commentedI added the array elements together in facetapi_bonus_facetapi_widgets. The radio buttons are now displaying!
1. On the filters tab, I keep getting the following errors, even if I don't select any options:
Contained fields field is required.
Contained fields field is required.
2. On global settings, I have the the "Limit to one active item" checked, and I have "Hide active items" unchecked in the facet's active filters. However, when I select an option (these are taxonomy terms), the rest of the items hide. I want all the items to display, even if not active. How do I configure that?
Comment #6
nlambert commentedFor others looking, this patch required #1393928: Add a per-facet setting that allows only one item to be active at a time which has been committed and is now included in the current facetapi version 1.5
In the display settings for the given facet, you must check "Limit to one active item"
@vintorg
I am not experiencing the errors mentioned in #1, but I believe you must change the "Minimum facet count" setting.
Comment #7
Johann Wagner commentedPatch #2 works great with version 7011.
Thank you.
Comment #8
Johann Wagner commentedI needed "real" radio buttons and also reduce JS to only auto-submit the form.
Though the patch #2 is working, without Javascript the link widget is displayed.
Please find attached a new widget that uses the FAPI's radios element instead, and that could be included to FacetAPI Bonus.
Unfortunately I've no time to make a patch, but the module file is short and self-explanatory.
Comment #9
jsacksick commentedPatch rerolled against latest dev, when you download the module via drush, the patch won't apply because of the .info modification, a possible workaround would be to add the class on top of the others...
Comment #10
selva8187 commentedPatch #2 working great. Thank you fago.
But One correction in that patch js file call : /js/facetapi_bonus_widget_links_radio.js
Comment #11
filsterjisah commentedI've tried to use patch from #2 via drush make but the patch failed to apply.
Therefor attached a "valid" one.
Comment #12
filsterjisah commentedComment #13
filsterjisah commentedThird ftw... This patch applies to version 1.1.
Comment #14
nareshbw commentedThanks Fago ,
Patch#2 is working for me.
Comment #15
thewilkybarkid commentedSame as #13, but have fixed CSS selector for fields through entity references.