Hello all,
I had this year filter with the total of results next to each option (see default.png)
Everytime I selected multiple years, the count of each year would be the total of all results (see active.png), which is wrong! It should keep the default values.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | facet_config_page.png | 93.98 KB | luispereira1317 |
| #9 | facet_config_click.png | 21.29 KB | luispereira1317 |
| #5 | default_1.png | 43.16 KB | luispereira1317 |
| #5 | active_1.png | 42.7 KB | luispereira1317 |
| #4 | 3050988-4--fix_OR_date_facet_counts.patch | 1.81 KB | drunken monkey |
Comments
Comment #2
luispereira1317 commentedComment #3
luispereira1317 commentedComment #4
drunken monkeyThanks a lot for reporting this!
You’re right, when finally providing basic OR support for date facets, we missed that part. However, while your patch should work in most cases, it doesn’t make sure that active items are always provided as options, even if the underlying search backend doesn’t return them.
I think my patch sould resolve that. Please test/review!
Comment #5
luispereira1317 commentedI just applied your patch and it's not working properly, at least in my case.
On the default screenshot (default_1.png) you can see the date options and when a date is selected (active_1.png) the exclude items are also being displayed, as you can see the "1970" option. If I select multi options, the filter disappears.
Comment #6
drunken monkeyCan you explain what you mean with “the exclude items”? Is there a result with a date in 1970 (or, more likely, 0/
FALSEas the date which gets incorrectly converted to Jan 1 1970)?Also, do you maybe just have the limit set to 10 items, so that the 1970 is present on the default page, too, but just not part of the first page?
Comment #7
luispereira1317 commentedUnder the page to configure the facet filters there is the option "Exclude specified items" and I added the year 1970. The date field on the node is filled in with the value 1970-01-01.
But there is also the problem of the filter disappearing after selecting, at least, two options.
Comment #8
drunken monkeyI don’t see that option. Can you tell me exactly where to find it, maybe with a screenshot or two?
Does it work correctly with your patch, and without any patch? (At least when setting to AND operator?)
In any case, I’d suggest for your specific case to fix your underlying data instead of relying on this option. But of course we should still make sure it works, if it is there.
Comment #9
luispereira1317 commentedCheck the two screenshots, the facet_config_click.png to open the configuration and in the facet_config_page.png to check the configuration. As you can see I am excluding the year 1970.
With my patch it works perfectly. I think my case is very specific...
Comment #10
drunken monkeyThat filter doesn’t seem part of the Facet API module. Can you tell me which module it comes from? Is it possible that the bug is just in the filter?
Comment #11
luispereira1317 commentedSo the module is https://www.drupal.org/project/facetapi_bonus
I also think the bug is related with this facetapi_bonus module.
Comment #12
drunken monkeyOK, then let’s see what the maintainers there say.
Comment #13
joseph.olstadtry the latest dev release, this issue might be fixed in latest release, if this issue still occurs then please provide helpful details.