File actions from VBO fail [#2903274]

Publishing / Unpublishing files using views bulk operations fails.

If not explicitly set in file_admin_action_info, 'behavior' defaults to 'changes_property' this causes the entity to be re-saved in views_bulk_operations/plugins/operation_types/action.class.php/execute() with the original value after _file_mass_update_helper() is called.

This can be stopped by setting `'behavior' => array('views_property'),` in `file_admin_action_info()`;

VBO docs here https://www.drupal.org/node/2052067

Comment	File	Size	Author
#6	file_admin_2903274-6.patch	602 bytes	mikkmiggur
#5	file_admin_2903274-5.patch	671 bytes	mikkmiggur
#4	2903274-1.patch	745 bytes	Dave Kopecek
#3	2903274-1.patch	745 bytes	Dave Kopecek

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

18 August 2017 at 21:43

Dave Kopecek created an issue. See original summary.

Comment #2

Dave Kopecek

he/him

CreditAttribution: Dave Kopecek as a volunteer and commented 27 August 2017 at 18:05

Comment removed.

Comment #3

Dave Kopecek

he/him

CreditAttribution: Dave Kopecek as a volunteer and commented 27 August 2017 at 18:07

Title:	File unpublish from VBO fails to update files of type `image`	» File actions from VBO fail
Issue summary:	View changes

File	Size
2903274-1.patch	745 bytes

Somehow resubmitted the same thing multiple times. Cleaning up. Because history.

Comment #4

Dave Kopecek

he/him

CreditAttribution: Dave Kopecek as a volunteer and commented 27 August 2017 at 18:03

Issue summary:

View changes

File	Size
2903274-1.patch	745 bytes

Comment #5

mikkmiggur CreditAttribution: mikkmiggur commented 12 December 2017 at 14:26

File	Size
file_admin_2903274-5.patch	671 bytes

There seems like not correct patch file. In patch file you are removing these lines but you need to add these.
And that behavior value can be just empty 'behavior' => array(''),
From VBO docs:

(When not specified, 'behavior' defaults to having the 'changes_property' behavior. This will trigger the save action, so if you intentionally want to avoid any save actions, set 'behavior' to an empty array.)