Flag API requires the flag type to be an entity.

It results in a notice when the token module is also enabled:

Notice: Undefined index: page in flag_token_info() (line 72 of sites/all/modules/contrib/flag/flag.tokens.inc).

CommentFileSizeAuthor
#3 flag_page-add_entity-2601234-3.patch5.06 KBRunePhilosof
#2 flag_page-add_entity-2601234-2.patch4.45 KBRunePhilosof
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RunePhilosof created an issue. See original summary.

RunePhilosof’s picture

RunePhilosof CreditAttribution: RunePhilosof commented
Status: Needs review » Needs work
FileSize
flag_page-add_entity-2601234-2.patch4.45 KB

This also changes the flag type to flag_page instead of page.
So it isn't backwards compatible.

Either it shouldn't change the flag type name or an update function should be added to convert existing.
Or we just ignore it, since it is just a -dev release.

RunePhilosof’s picture

RunePhilosof CreditAttribution: RunePhilosof commented
Status: Needs work » Needs review
FileSize
flag_page-add_entity-2601234-3.patch5.06 KB

The patch had the entity addition commented out because I forgot to remove the comments after generating the error message.

Fixed in this one